[clang] [clang][deps] Use `ModuleDepCollector` for Make output (PR #182063)
Jan Svoboda via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 19 15:51:33 PST 2026
================
@@ -950,12 +957,9 @@ void ModuleDepCollector::addVisibleModules() {
static StringRef makeAbsoluteAndPreferred(CompilerInstance &CI, StringRef Path,
SmallVectorImpl<char> &Storage) {
- if (llvm::sys::path::is_absolute(Path) &&
- !llvm::sys::path::is_style_windows(llvm::sys::path::Style::native))
- return Path;
----------------
jansvoboda11 wrote:
This is just an optimization to not re allocate the path if it's absolute and doesn't need separator canonicalization. Now that that I need to call `remove_dots()` (https://github.com/llvm/llvm-project/pull/182063#discussion_r2823411756), I'd need to check that this path doesn't contain dot components to see if it's safe to skip the code below. So I decided to just drop the optimization entirely.
https://github.com/llvm/llvm-project/pull/182063
More information about the cfe-commits
mailing list