[clang] [HIP][Sema] Fix incorrect CK_NoOp for lvalue-to-rvalue conversion in … (PR #180314)

[Erich Keane via cfe-commits]

================
@@ -6823,9 +6823,10 @@ ExprResult Sema::BuildCallExpr(Scope *Scope, Expr *Fn, SourceLocation LParenLoc,
 
         // First, ensure that the Arg is an RValue.
----------------
erichkeane wrote:

Heh, it is actually correct, and well formulated... for someone who knew what they were writing at the time.  I agree it is definitely confusing.  BUT the idea is that IF this is a GL-Value, it converts arg is an RValue (via the `DefaultLvalueConversion` function).  I might suggest changing this to:

`First, convert the Arg to an RValue if it is not already` or something.

https://github.com/llvm/llvm-project/pull/180314