[clang] Diagnose potential size confusion with VLA params [contd.] (PR #181550)

[Aaron Ballman via cfe-commits]

================
@@ -4239,6 +4239,10 @@ class Sema final : public SemaBase {
   /// ParmVarDecl pointers.
   void DiagnoseUnusedParameters(ArrayRef<ParmVarDecl *> Parameters);
 
+  /// Diagnose vla size declaration confusion between file scope variables
+  /// and function parameters
+  void DiagnoseVlaSizeParameter(const SmallVector<ParmVarDecl *, 16> &Params);
----------------
AaronBallman wrote:

```suggestion
  void DiagnoseVlaSizeParameter(const SmallVectorImpl<ParmVarDecl *> &Params);
```
A more generic type so users can call with any sized `SmallVector<ParmVarDecl *>`

https://github.com/llvm/llvm-project/pull/181550