[clang] [Clang] Fix assertion failure in SDiagsWriter when finish() is not called (PR #181712)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 52553 tests passed
* 959 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.Tooling/serialize-diagnostics.cpp</summary>

```
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\clang-check.exe C:\_work\llvm-project\llvm-project\clang\test\Tooling\serialize-diagnostics.cpp -- -Wunknown-warning-option --serialize-diagnostics C:\_work\llvm-project\llvm-project\build\tools\clang\test\Tooling\Output\serialize-diagnostics.cpp.tmp.dia 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\clang\test\Tooling\serialize-diagnostics.cpp --allow-empty
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang-check.exe' 'C:\_work\llvm-project\llvm-project\clang\test\Tooling\serialize-diagnostics.cpp' -- -Wunknown-warning-option --serialize-diagnostics 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\Tooling\Output\serialize-diagnostics.cpp.tmp.dia'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\clang\test\Tooling\serialize-diagnostics.cpp' --allow-empty
# .---command stderr------------
# | error: no check strings found with prefix 'CHECK:'
# `-----------------------------
# error: command failed with exit status: 2

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/181712