[clang] [Clang][CodeGen] Fix crash on value-dependent initializer during error recovery (PR #181561)

[Shafik Yaghmour via cfe-commits]

================
@@ -2593,7 +2593,11 @@ APValue *VarDecl::evaluateValueImpl(SmallVectorImpl<PartialDiagnosticAt> &Notes,
   EvaluatedStmt *Eval = ensureEvaluatedStmt();
 
   const auto *Init = getInit();
-  assert(!Init->isValueDependent());
----------------
shafik wrote:

You need to justify why this is not correct and why the new code is.

Looks like this assert was brought in by 76c0092665867

CC @zygoloid 

https://github.com/llvm/llvm-project/pull/181561