[clang] [LifetimeSafety] 'erase' does not invaldiate node-based containers (PR #181216)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `clang` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/15456

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: functionalities/breakpoint/break_in_loaded_dylib/TestBreakInLoadedDylib.py (315 of 2448)
UNSUPPORTED: lldb-api :: functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py (316 of 2448)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py (317 of 2448)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_command/TestBreakpointCommandsFromPython.py (318 of 2448)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py (319 of 2448)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py (320 of 2448)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py (321 of 2448)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_ids/TestBreakpointIDs.py (322 of 2448)
UNSUPPORTED: lldb-api :: functionalities/breakpoint/breakpoint_ignore_count/TestBreakpointIgnoreCount.py (323 of 2448)
UNSUPPORTED: lldb-api :: functionalities/breakpoint/breakpoint_in_delayslot/TestAvoidBreakpointInDelaySlot.py (324 of 2448)
FAIL: lldb-api :: functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py (325 of 2448)
******************** TEST 'lldb-api :: functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py' FAILED ********************
Script:
--
C:/Users/tcwg/scoop/apps/python/current/python.exe C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --env LLVM_INCLUDE_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/include --env LLVM_TOOLS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --arch aarch64 --build-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex --lldb-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-lldb\lldb-api --clang-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-api --executable C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/lldb.exe --compiler C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/clang.exe --dsymutil C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/dsymutil.exe --make C:/Users/tcwg/scoop/shims/make.exe --llvm-tools-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --lldb-obj-root C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb --lldb-libs-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --cmake-build-type Release --skip-category=watchpoint C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\breakpoint\breakpoint_conditions -p TestBreakpointConditions.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 23.0.0git (https://github.com/llvm/llvm-project.git revision e819483c20ea502e9a0f3cc29276cc05a3f35e98)
  clang revision e819483c20ea502e9a0f3cc29276cc05a3f35e98
  llvm revision e819483c20ea502e9a0f3cc29276cc05a3f35e98
a(1) returns 4

b(2) returns 5

a(3) returns 6

Loop

Loop

a(1) returns 4

b(2) returns 5

a(3) returns 6

Loop

Loop

Skipping the following test categories: watchpoint, libc++, libstdcxx, dwo, dsym, gmodules, debugserver, objc, fork, pexpect


--
Command Output (stderr):
--

```

</details>

https://github.com/llvm/llvm-project/pull/181216