[clang] [NFC][analyzer] Remove StmtNodeBuilder (PR #181431)

[Donát Nagy via cfe-commits]

================
@@ -132,6 +132,9 @@ void rdar7342806(void) {
 //  Note: CheckerVisit mistakenly cleared an existing node, and the cleared
 //  node was resurrected by GRStmtNodeBuilder::~GRStmtNodeBuilder(), where
 //  'p' was not assigned.
+//  Note 2: This "resurrecting" destructor was removed from the codebase by
+//  commit 320d0b5467b9586a188e06dd2620126f5cb99318 (in 2026) because it was
+//  already dead code at that time.
----------------
NagyDonat wrote:

I found this comment in the output of `git grep StmtNodeBuilder` and added this note because I was barely able to understand what the previous note refers to and I instinctively tried to preserve this information.

However, you are right that probably the whole big comment block is useless and could be replaced by "This testcase was added as a regression test for a bug within some complex internals of the analyzer engine, which no longer exist."

I'm not opposed to also removing the testcase, but random extra coverage (almost) never hurts.

https://github.com/llvm/llvm-project/pull/181431