[clang] [clang][CFG] Sequence RHS before LHS for overloaded assignment operators in CFG to match C++17 rules (PR #181113)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/24776

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: functionalities/data-formatter/data-formatter-skip-summary/TestDataFormatterSkipSummary.py (403 of 2700)
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/atomic/TestDataFormatterStdAtomic.py (404 of 2700)
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/chrono/TestDataFormatterStdChrono.py (405 of 2700)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py (406 of 2700)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/bitset/TestDataFormatterGenericBitset.py (407 of 2700)
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/function/TestDataFormatterStdFunction.py (408 of 2700)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/deque/TestDataFormatterGenericDeque.py (409 of 2700)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/initializer_list/TestDataFormatterStdInitializerList.py (410 of 2700)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/forward_list/TestDataFormatterGenericForwardList.py (411 of 2700)
UNRESOLVED: lldb-api :: driver/quit_speed/TestQuitWithProcess.py (412 of 2700)
******************** TEST 'lldb-api :: driver/quit_speed/TestQuitWithProcess.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin --arch armv8l --build-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./lib --cmake-build-type Release /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/driver/quit_speed -p TestQuitWithProcess.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 23.0.0git (https://github.com/llvm/llvm-project.git revision 47abe868314d2b2d71d188723bda41ea3d4641f7)
  clang revision 47abe868314d2b2d71d188723bda41ea3d4641f7
  llvm revision 47abe868314d2b2d71d188723bda41ea3d4641f7
Skipping the following test categories: libc++, msvcstl, dsym, pdb, gmodules, debugserver, objc
launched process
Got launch message
sent quit
launched process
Got launch message
sent quit

--
Command Output (stderr):
--
FAIL: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_run_quit (TestQuitWithProcess.DriverQuitSpeedTest)
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_run_quit_with_prompt (TestQuitWithProcess.DriverQuitSpeedTest)
======================================================================
ERROR: test_run_quit (TestQuitWithProcess.DriverQuitSpeedTest)
   Test that the lldb driver's batch mode works correctly.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 160, in wrapper
    return func(*args, **kwargs)
  File "/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/driver/quit_speed/TestQuitWithProcess.py", line 35, in test_run_quit
    child.expect(pexpect.EOF, timeout=15)
  File "/usr/local/lib/python3.10/dist-packages/pexpect/spawnbase.py", line 354, in expect
    return self.expect_list(compiled_pattern_list,
  File "/usr/local/lib/python3.10/dist-packages/pexpect/spawnbase.py", line 383, in expect_list
    return exp.expect_loop(timeout)
  File "/usr/local/lib/python3.10/dist-packages/pexpect/expect.py", line 181, in expect_loop

```

</details>

https://github.com/llvm/llvm-project/pull/181113