[clang-tools-extra] [clang-tidy] identifier-naming: TrimPrefixSuffix option to avoid concatenating multiple pre(suf)fixes (PR #181502)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-trim.cpp clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
index 8de8d7089..0989c2fa4 100644
--- a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
@@ -273,8 +273,7 @@ IdentifierNamingCheck::FileStyle IdentifierNamingCheck::getFileStyleFromOptions(
 
     memcpy(&StyleString[StyleSize], "TrimPrefixSuffix", 16);
     StyleString.truncate(StyleSize + 16);
-    const std::optional<bool> TrimPrefixSuffix =
-        Options.get<bool>(StyleString);
+    const std::optional<bool> TrimPrefixSuffix = Options.get<bool>(StyleString);
     memcpy(&StyleString[StyleSize], "IgnoredRegexp", 13);
     StyleString.truncate(StyleSize + 13);
     std::optional<StringRef> IgnoredRegexpStr = Options.get(StyleString);
@@ -1104,7 +1103,8 @@ static void trimPrefixesAndSuffixes(
                Mid.consume_front(OtherStyle->Prefix))
           LoopWhileToRemove = true;
 
-        while (!OtherStyle->Suffix.empty() && Mid.consume_back(OtherStyle->Suffix))
+        while (!OtherStyle->Suffix.empty() &&
+               Mid.consume_back(OtherStyle->Suffix))
           LoopWhileToRemove = true;
       }
     }
diff --git a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
index bdac7f5b1..e7925daf8 100644
--- a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
+++ b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
@@ -175,12 +175,12 @@ public:
                 const IdentifierNamingCheck::HungarianNotationOption &HNOption,
                 IdentifierNamingCheck::CaseType Case) const;
 
-  std::string
-  fixupWithStyle(StringRef Type, StringRef Name,
-                 const IdentifierNamingCheck::NamingStyle &Style,
-                 ArrayRef<std::optional<IdentifierNamingCheck::NamingStyle>> NamingStyles,
-                 const IdentifierNamingCheck::HungarianNotationOption &HNOption,
-                 const Decl *D) const;
+  std::string fixupWithStyle(
+      StringRef Type, StringRef Name,
+      const IdentifierNamingCheck::NamingStyle &Style,
+      ArrayRef<std::optional<IdentifierNamingCheck::NamingStyle>> NamingStyles,
+      const IdentifierNamingCheck::HungarianNotationOption &HNOption,
+      const Decl *D) const;
 
   StyleKind findStyleKind(
       const NamedDecl *D,

``````````

</details>


https://github.com/llvm/llvm-project/pull/181502