[clang-tools-extra] [clang-tidy] Add redundant qualified alias check (PR #180404)

[Daniil Dudkin via cfe-commits]

================
@@ -0,0 +1,270 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "RedundantQualifiedAliasCheck.h"
+#include "../utils/LexerUtils.h"
+#include "clang/AST/Decl.h"
+#include "clang/AST/TypeLoc.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Basic/SourceManager.h"
+#include "clang/Lex/Lexer.h"
+#include <optional>
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::readability {
+
+namespace {
+
+struct NominalTypeLocInfo {
+  TypeLoc Loc;
+  bool HasQualifier = false;
+};
+
+struct EqualTokenInfo {
+  SourceLocation AfterEqualLoc;
+  bool SawComment = false;
+};
+
+} // namespace
+
+static bool hasMacroInRange(SourceRange Range, const SourceManager &SM,
+                            const LangOptions &LangOpts) {
+  if (Range.isInvalid())
+    return true;
+  return utils::lexer::rangeContainsExpansionsOrDirectives(Range, SM, LangOpts);
+}
+
+static std::optional<NominalTypeLocInfo> peelToNominalTypeLoc(TypeLoc TL) {
+  while (!TL.isNull()) {
+    if (const auto ParenTL = TL.getAs<ParenTypeLoc>()) {
+      TL = ParenTL.getInnerLoc();
+      continue;
+    }
----------------
unterumarmung wrote:

Good catch. I removed the `ParenTypeLoc` peel path. For alias RHS, a top-level parenthesized type like `using T = (ns::T);` is invalid C++, so that branch was not reachable for rewriteable aliases. The `ParenTypeLoc` nodes we do see are inside non-nominal declarator shapes (e.g. function-pointer style forms), where this check intentionally does not fire anyway. I kept coverage for reachable cases and added C++23 init-statement negatives.

https://github.com/llvm/llvm-project/pull/180404