[clang-tools-extra] [clang-tidy] Fix performance-trivially-destructible with C++20 modules (PR #178471)

[Aaron Ballman via cfe-commits]

================
@@ -51,6 +51,9 @@ set(CLANG_TOOLS_TEST_DEPS
   clang-resource-headers
 
   clang-tidy
+
+  # Some tests invoke clang directly (e.g., to precompile modules).
+  clang
----------------
AaronBallman wrote:

This feels like a heavy dependency at first, but I think it may not be as bad as at first glance. Functionally, you end up building basically all of clang when you build clang-tidy. I think it's pretty rare that you would update a test (without updating clang-tidy) in a way where this overhead would be unexpected.

This does seem like another (small) reason why clang-tidy should integrate directly into Clang at some point.

CC @petrhosek in case I'm missing anything, but this seems defensible to me.

https://github.com/llvm/llvm-project/pull/178471