[clang] [NFCI][analyzer] Regularize NodeBuilder classes (PR #180960)

[Donát Nagy via cfe-commits]

================
@@ -425,12 +425,23 @@ void CoreEngine::HandleBlockExit(const CFGBlock * B, ExplodedNode *Pred) {
       case Stmt::IndirectGotoStmtClass: {
         // Only 1 successor: the indirect goto dispatch block.
         assert(B->succ_size() == 1);
-
-        IndirectGotoNodeBuilder
-           builder(Pred, B, cast<IndirectGotoStmt>(Term)->getTarget(),
-                   *(B->succ_begin()), this);
-
-        ExprEng.processIndirectGoto(builder);
+        NodeBuilderContext Ctx(*this, B, Pred);
+        ExplodedNodeSet Dst;
+        IndirectGotoNodeBuilder Builder(
+            Pred, Dst, Ctx, cast<IndirectGotoStmt>(Term)->getTarget(),
+            *(B->succ_begin()));
+
+        ExprEng.processIndirectGoto(Builder, Pred);
+        // Enqueue the new frontier onto the worklist.
+        llvm::errs() << "Pred location is ";
----------------
NagyDonat wrote:

No, they are absolutely not intentional :sweat_smile: Thanks for catching them!

https://github.com/llvm/llvm-project/pull/180960