[clang] Add check in SemaChecking for multiple unsequenced volatile accesses (PR #180955)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 11 06:52:53 PST 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/warn-unsequenced.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index b9d1ae924..4c2eaad98 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -14034,11 +14034,7 @@ class SequenceChecker : public ConstEvaluatedExprVisitor<SequenceChecker> {
UK_Count = UK_ModAsSideEffect + 1
};
- enum WarningKind {
- WK_UseAndMod,
- WK_ModAndMod,
- WK_Volatile_UseAndUse
- };
+ enum WarningKind { WK_UseAndMod, WK_ModAndMod, WK_Volatile_UseAndUse };
/// Bundle together a sequencing region and the expression corresponding
/// to a specific usage. One Usage is stored for each usage kind in UsageInfo.
@@ -14203,7 +14199,7 @@ class SequenceChecker : public ConstEvaluatedExprVisitor<SequenceChecker> {
case WK_UseAndMod:
DiagID = diag::warn_unsequenced_mod_use;
break;
- case WK_ModAndMod:
+ case WK_ModAndMod:
DiagID = diag::warn_unsequenced_mod_mod;
break;
case WK_Volatile_UseAndUse:
@@ -14213,7 +14209,7 @@ class SequenceChecker : public ConstEvaluatedExprVisitor<SequenceChecker> {
SemaRef.DiagRuntimeBehavior(
Mod->getExprLoc(), {Mod, ModOrUse},
- SemaRef.PDiag(DiagID)<< O << SourceRange(ModOrUse->getExprLoc()));
+ SemaRef.PDiag(DiagID) << O << SourceRange(ModOrUse->getExprLoc()));
UI.Diagnosed = true;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/180955
More information about the cfe-commits
mailing list