[clang-tools-extra] [clangd] Apply modernize-use-string-view to the code#180332 (PR #180335)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-tools-extra

Author: Zinovy Nis (irishrover)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/180335.diff


3 Files Affected:

- (modified) clang-tools-extra/clangd/Feature.cpp (+1-1) 
- (modified) clang-tools-extra/clangd/Feature.h (+2-1) 
- (modified) clang-tools-extra/clangd/SymbolDocumentation.cpp (+3-2) 


``````````diff
diff --git a/clang-tools-extra/clangd/Feature.cpp b/clang-tools-extra/clangd/Feature.cpp
index ec707a33f656b..fbae381911b89 100644
--- a/clang-tools-extra/clangd/Feature.cpp
+++ b/clang-tools-extra/clangd/Feature.cpp
@@ -30,7 +30,7 @@ std::string platformString() {
   return PlatformString;
 }
 
-std::string featureString() {
+llvm::StringRef featureString() {
   return
 #if defined(_WIN32)
       "windows"
diff --git a/clang-tools-extra/clangd/Feature.h b/clang-tools-extra/clangd/Feature.h
index ba958fc49c020..0539a07a3e786 100644
--- a/clang-tools-extra/clangd/Feature.h
+++ b/clang-tools-extra/clangd/Feature.h
@@ -15,6 +15,7 @@
 
 // Export constants like CLANGD_BUILD_XPC
 #include "Features.inc"
+#include "llvm/ADT/StringRef.h"
 
 namespace clang {
 namespace clangd {
@@ -28,7 +29,7 @@ std::string platformString();
 
 // Returns a string describing the compile-time configuration.
 // e.g. mac+debug+asan+grpc
-std::string featureString();
+llvm::StringRef featureString();
 
 } // namespace clangd
 } // namespace clang
diff --git a/clang-tools-extra/clangd/SymbolDocumentation.cpp b/clang-tools-extra/clangd/SymbolDocumentation.cpp
index a50d7a565b1bc..37cfa84078590 100644
--- a/clang-tools-extra/clangd/SymbolDocumentation.cpp
+++ b/clang-tools-extra/clangd/SymbolDocumentation.cpp
@@ -20,7 +20,8 @@ namespace clang {
 namespace clangd {
 namespace {
 
-std::string commandMarkerAsString(comments::CommandMarkerKind CommandMarker) {
+llvm::StringRef
+commandMarkerAsString(comments::CommandMarkerKind CommandMarker) {
   switch (CommandMarker) {
   case comments::CommandMarkerKind::CMK_At:
     return "@";
@@ -33,7 +34,7 @@ std::string commandMarkerAsString(comments::CommandMarkerKind CommandMarker) {
 void commandToMarkup(markup::Paragraph &Out, StringRef Command,
                      comments::CommandMarkerKind CommandMarker,
                      StringRef Args) {
-  Out.appendBoldText(commandMarkerAsString(CommandMarker) + Command.str());
+  Out.appendBoldText((commandMarkerAsString(CommandMarker) + Command).str());
   Out.appendSpace();
   if (!Args.empty())
     Out.appendCode(Args.str());

``````````

</details>


https://github.com/llvm/llvm-project/pull/180335