[clang] [WinEH] Fix object delete crash (PR #180144)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 86042 tests passed
* 1240 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.CodeGen/windows-seh-EHa-TryInFinally.cpp</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/23/include -nostdsysteminc -triple x86_64-windows -fasync-exceptions -fcxx-exceptions -fexceptions -fms-extensions -x c++ -Wno-implicit-function-declaration -emit-llvm /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGen/windows-seh-EHa-TryInFinally.cpp -o - | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGen/windows-seh-EHa-TryInFinally.cpp
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/23/include -nostdsysteminc -triple x86_64-windows -fasync-exceptions -fcxx-exceptions -fexceptions -fms-extensions -x c++ -Wno-implicit-function-declaration -emit-llvm /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGen/windows-seh-EHa-TryInFinally.cpp -o -
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGen/windows-seh-EHa-TryInFinally.cpp
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGen/windows-seh-EHa-TryInFinally.cpp:9:11: error: CHECK: expected string not found in input
# | // CHECK: invoke void @llvm.seh.try.end()
# |           ^
# | <stdin>:80:33: note: scanning from here
# |  invoke void @llvm.seh.try.end()
# |                                 ^
# | <stdin>:145:2: note: possible intended match here
# |  invoke void @llvm.seh.try.begin()
# |  ^
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGen/windows-seh-EHa-TryInFinally.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |            .
# |            .
# |            .
# |           75:  %5 = call ptr @llvm.localaddress() 
# |           76:  invoke void @"?fin$0 at 0@main@@"(i8 noundef 0, ptr noundef %5) #8 
# |           77:  to label %invoke.cont5 unwind label %catch.dispatch 
# |           78:  
# |           79: invoke.cont5: ; preds = %if.end 
# |           80:  invoke void @llvm.seh.try.end() 
# | check:9'0                                     X error: no match found
# |           81:  to label %invoke.cont8 unwind label %catch.dispatch 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           82:  
# | check:9'0     ~
# |           83: catch.dispatch: ; preds = %invoke.cont5, %invoke.cont7, %invoke.cont6, %ehcleanup, %if.end, %for.body 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           84:  %6 = catchswitch within none [label %__except] unwind to caller 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           85:  
# | check:9'0     ~
# |            .
# |            .
# |            .
# |          140:  store i8 %abnormal_termination, ptr %abnormal_termination.addr, align 1 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          141:  invoke void @llvm.seh.scope.begin() 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          142:  to label %invoke.cont unwind label %ehcleanup 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          143:  
# | check:9'0     ~
# |          144: invoke.cont: ; preds = %entry 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          145:  invoke void @llvm.seh.try.begin() 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | check:9'1      ?                                  possible intended match
# |          146:  to label %invoke.cont1 unwind label %ehcleanup 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          147:  
# | check:9'0     ~
# |          148: invoke.cont1: ; preds = %invoke.cont 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          149:  %0 = load volatile i32, ptr %i, align 4 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          150:  invoke void (...) @"?printf@@YAXZZ"(ptr noundef @"??_C at _0BN@HAIIIOKI@?5?5In?5outer?5_finally?5i?5?$DN?5?$CFd?5?6?$AA@", i32 noundef %0) #8 
# | check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            .
# |            .
# |            .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/180144