[clang] [Clang] Fix atomic boolean compound assignment (#33210) (PR #178220)

via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 5 08:18:15 PST 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,c -- clang/test/CodeGen/compound-assign-atomic-bool.c clang/lib/CodeGen/CGExprScalar.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CodeGen/CGExprScalar.cpp b/clang/lib/CodeGen/CGExprScalar.cpp
index 2a36a5e94..204938e30 100644
--- a/clang/lib/CodeGen/CGExprScalar.cpp
+++ b/clang/lib/CodeGen/CGExprScalar.cpp
@@ -4039,14 +4039,14 @@ LValue ScalarExprEmitter::EmitCompoundAssignLValue(
     Previous = Result;
     Result = EmitScalarConversion(Result, PromotionTypeCR, LHSTy, Loc);
   } else if (const auto *atomicTy = LHSTy->getAs<AtomicType>()) {
-    Result = EmitScalarConversion(Result, PromotionTypeCR,
-                                  atomicTy->getValueType(), Loc,
-                                  ScalarConversionOpts(CGF.SanOpts));
+    Result =
+        EmitScalarConversion(Result, PromotionTypeCR, atomicTy->getValueType(),
+                             Loc, ScalarConversionOpts(CGF.SanOpts));
   } else {
     Result = EmitScalarConversion(Result, PromotionTypeCR, LHSTy, Loc,
                                   ScalarConversionOpts(CGF.SanOpts));
   }
-  
+
   if (atomicPHI) {
     llvm::BasicBlock *curBlock = Builder.GetInsertBlock();
     llvm::BasicBlock *contBB = CGF.createBasicBlock("atomic_cont", CGF.CurFn);

``````````

</details>


https://github.com/llvm/llvm-project/pull/178220


More information about the cfe-commits mailing list