[clang] [NFC][analyzer] Cleanup dead code around NodeBuilder (PR #179711)

[Donát Nagy via cfe-commits]

NagyDonat wrote:

I will probably create a few other NFC (or almost-NFC) commits in this area because I want to understand the code and once I understand it, it is not too difficult to create commits that eliminate the glaring code quality issues.

@ reviewers: I added you to this PR to let you know that I'm working on this area, but I understand if you don't want to give an in-depth review for this sort of cleanup commit. If you are not interested, feel free to say so, and I won't add you as reviewers for analogous commits.

@steakhal You might be a bit interested in this PR because commit https://github.com/llvm/llvm-project/pull/179711/commits/4094819dfa0b2b23710e9db928393b1382cde9c3 touches code that is slightly connected to the new BlockEntrance callback.

I uploaded the changes in this PR as three separate commits to make the review a bit easier, but I will probably squash them when I merge this PR if nobody objects.



https://github.com/llvm/llvm-project/pull/179711