[clang] Upstream support for ATan2Op (FPToFPBuiltin) (PR #179078)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Jan 31 17:17:54 PST 2026
github-actions[bot] wrote:
<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results
* 3103 tests passed
* 7 tests skipped
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.
<details>
<summary>tools/clang/lib/CIR/CodeGen/CMakeFiles/obj.clangCIR.dir/CIRGenBuiltin.cpp.o</summary>
```
FAILED: tools/clang/lib/CIR/CodeGen/CMakeFiles/obj.clangCIR.dir/CIRGenBuiltin.cpp.o
sccache /opt/llvm/bin/clang++ -DCLANG_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/lib/CIR/CodeGen -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/CodeGen -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/../mlir/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/mlir/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/clang/lib/CIR/CodeGen/CMakeFiles/obj.clangCIR.dir/CIRGenBuiltin.cpp.o -MF tools/clang/lib/CIR/CodeGen/CMakeFiles/obj.clangCIR.dir/CIRGenBuiltin.cpp.o.d -o tools/clang/lib/CIR/CodeGen/CMakeFiles/obj.clangCIR.dir/CIRGenBuiltin.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp:1231:37: error: no member named 'ATan2Op' in namespace 'cir'
1231 | return emitBinaryFPBuiltin<cir::ATan2Op>(*this, *e);
| ^~~~~~~
1 error generated.
```
</details>
<details>
<summary>tools/clang/lib/CIR/Lowering/DirectToLLVM/CMakeFiles/obj.clangCIRLoweringDirectToLLVM.dir/LowerToLLVM.cpp.o</summary>
```
FAILED: tools/clang/lib/CIR/Lowering/DirectToLLVM/CMakeFiles/obj.clangCIRLoweringDirectToLLVM.dir/LowerToLLVM.cpp.o
sccache /opt/llvm/bin/clang++ -DCLANG_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/lib/CIR/Lowering/DirectToLLVM -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/../mlir/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/mlir/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Dialect/Transforms/TargetLowering -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/clang/lib/CIR/Lowering/DirectToLLVM/CMakeFiles/obj.clangCIRLoweringDirectToLLVM.dir/LowerToLLVM.cpp.o -MF tools/clang/lib/CIR/Lowering/DirectToLLVM/CMakeFiles/obj.clangCIRLoweringDirectToLLVM.dir/LowerToLLVM.cpp.o.d -o tools/clang/lib/CIR/Lowering/DirectToLLVM/CMakeFiles/obj.clangCIRLoweringDirectToLLVM.dir/LowerToLLVM.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:1558:21: error: use of undeclared identifier 'CIRToLLVMATan2OpLowering'; did you mean 'CIRToLLVMATanOpLowering'?
1558 | mlir::LogicalResult CIRToLLVMATan2OpLowering::matchAndRewrite(
| ^~~~~~~~~~~~~~~~~~~~~~~~
| CIRToLLVMATanOpLowering
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include/clang/CIR/Dialect/IR/CIRLowering.inc:197:7: note: 'CIRToLLVMATanOpLowering' declared here
197 | class CIRToLLVMATanOpLowering : public mlir::OpConversionPattern<cir::ATanOp> {
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:1558:21: error: use of undeclared identifier 'CIRToLLVMATan2OpLowering'; did you mean 'CIRToLLVMATanOpLowering'?
1558 | mlir::LogicalResult CIRToLLVMATan2OpLowering::matchAndRewrite(
| ^~~~~~~~~~~~~~~~~~~~~~~~
| CIRToLLVMATanOpLowering
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include/clang/CIR/Dialect/IR/CIRLowering.inc:197:7: note: 'CIRToLLVMATanOpLowering' declared here
197 | class CIRToLLVMATanOpLowering : public mlir::OpConversionPattern<cir::ATanOp> {
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:1559:10: error: no type named 'ATan2Op' in namespace 'cir'; did you mean 'ATanOp'?
1559 | cir::ATan2Op op, OpAdaptor adaptor,
| ~~~~~^~~~~~~
| ATanOp
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include/clang/CIR/Dialect/IR/CIROps.h.inc:3691:7: note: 'ATanOp' declared here
3691 | class ATanOp : public ::mlir::Op<ATanOp, ::mlir::OpTrait::ZeroRegions, ::mlir::OpTrait::OneResult, ::mlir::OpTrait::OneTypedResult<::mlir::Type>::Impl, ::mlir::OpTrait::ZeroSuccessors, ::mlir::OpTrait::OneOperand, ::mlir::OpTrait::OpInvariants, ::mlir::ConditionallySpeculatable::Trait, ::mlir::OpTrait::AlwaysSpeculatableImplTrait, ::mlir::MemoryEffectOpInterface::Trait, ::mlir::OpTrait::SameOperandsAndResultType, ::mlir::InferTypeOpInterface::Trait> {
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:1558:47: error: redefinition of 'matchAndRewrite'
1558 | mlir::LogicalResult CIRToLLVMATan2OpLowering::matchAndRewrite(
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:1550:46: note: previous definition is here
1550 | mlir::LogicalResult CIRToLLVMATanOpLowering::matchAndRewrite(
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:1562:71: error: no member named 'getLhs' in 'cir::ATanOpAdaptor'
1562 | rewriter.replaceOpWithNewOp<mlir::LLVM::ATan2Op>(op, resTy, adaptor.getLhs(),
| ~~~~~~~ ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:1563:60: error: no member named 'getRhs' in 'cir::ATanOpAdaptor'
1563 | adaptor.getRhs());
| ~~~~~~~ ^
6 errors generated.
```
</details>
If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.
https://github.com/llvm/llvm-project/pull/179078
More information about the cfe-commits
mailing list