[clang] [clang] Store the Input PCH Path Using Absolute Paths in a PCH (PR #178781)

[Cyndy Ishida via cfe-commits]

================
@@ -1752,7 +1752,10 @@ void ASTWriter::WriteControlBlock(Preprocessor &PP, StringRef isysroot) {
   Record.push_back(PPOpts.UsePredefines);
   // Detailed record is important since it is used for the module cache hash.
   Record.push_back(PPOpts.DetailedRecord);
-  AddString(PPOpts.ImplicitPCHInclude, Record);
+  if (PPOpts.ImplicitPCHInclude.empty())
+    AddString(PPOpts.ImplicitPCHInclude, Record);
----------------
cyndyishida wrote:

> I modify AddPath, we are checking for something that is not likely to happen for the more common cases.

Why is that bad?

https://github.com/llvm/llvm-project/pull/178781