[clang] [mlir] [CIR] Implement lowering for 'no-builtins' attributes (PR #178899)

Tobias Gysi via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 30 09:30:37 PST 2026


================
@@ -349,6 +349,27 @@ class ModuleTranslation {
 
   SymbolTableCollection &symbolTable() { return symbolTableCollection; }
 
+  // A helper callback that takes an attribute, and if it is a StringAttr,
+  // properly converts it to the 'no-builtin-VALUE' form.
+  static std::optional<std::string> noBuiltinConverter(mlir::Attribute a) {
----------------
gysit wrote:

```suggestion
  static std::optional<std::string> convertNoBuiltin(Attribute a) {
```
nit: I believe the coding convention wants a verb first.

https://github.com/llvm/llvm-project/pull/178899


More information about the cfe-commits mailing list