https://github.com/erichkeane commented: Alright, i think I got all your comments! I generalized the array->attribute addition, though it is mildly constrained by the types that 'attribute' takes in its ctor. WDYT? https://github.com/llvm/llvm-project/pull/178899