[clang] [lld] [llvm] [LTO] Make stack usage files work with LTO (PR #178005)

Teresa Johnson via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 28 08:30:42 PST 2026


================
@@ -106,6 +106,11 @@ static cl::opt<std::string>
     LTOStatsFile("lto-stats-file",
                  cl::desc("Save statistics to the specified file"), cl::Hidden);
 
+cl::opt<std::string>
+    LTOStackUsageOutput("lto-stack-usage-output",
----------------
teresajohnson wrote:

Yeah I would remove the lld and llvm-lto tests, and add an AsmPrinter test. I'd then suggest splitting this into 3 PRs:
1) The renaming change - you can mark this as NFC and go ahead and commit without further review, lgtm on that change.
2) The AsmPrinter change, with a dedicated test. You can probably reuse the llvm-lto2 test and change it to test via llc. That should probably go in llvm/test/CodeGen/X86/, in which case you also don't need the REQUIRES: x86-registered-target.
3) The clang Darwin change, probably tagged something like "[Driver][Darwin] Pass stack usage file for LTO"

Also, just a request to avoid force pushing if at all possible - it makes comparing to earlier reviewed commits in the PR impossible. See also https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes.

https://github.com/llvm/llvm-project/pull/178005


More information about the cfe-commits mailing list