[clang] [clang][analyzer] Add taintedness to argv (PR #178054)

[Balázs Benics via cfe-commits]

================
@@ -827,8 +831,40 @@ void GenericTaintChecker::initTaintRules(CheckerContext &C) const {
                             std::make_move_iterator(Rules.end()));
 }
 
+// The incoming parameters of the main function get tainted
+// if the program called in an untrusted environment.
+void GenericTaintChecker::checkBeginFunction(CheckerContext &C) const {
+  if (!C.inTopFrame() || C.getAnalysisManager()
+                             .getAnalyzerOptions()
+                             .ShouldAssumeControlledEnvironment)
+    return;
+
+  const auto *FD = dyn_cast<FunctionDecl>(C.getLocationContext()->getDecl());
+  if (!FD || !FD->isMain() || FD->param_size() < 2)
----------------
steakhal wrote:

Have you considered extending `ExprEngine::getInitialState()` with this special logic?
IMO if there is already place for handling "special" hacks for "main", we should at least strive for having them together.

https://github.com/llvm/llvm-project/pull/178054