[clang] macCatalyst: add SDKSettings.json as a dependency file if its potentially needed by the compiler (PR #177748)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3031 tests passed
* 29 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/clang/unittests/Basic/CMakeFiles/BasicTests.dir/DarwinSDKInfoTest.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/unittests/Basic/CMakeFiles/BasicTests.dir/DarwinSDKInfoTest.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\clang\unittests\Basic -IC:\_work\llvm-project\llvm-project\clang\unittests\Basic -IC:\_work\llvm-project\llvm-project\clang\include -Itools\clang\include -Iinclude -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -MD -UNDEBUG -Wno-gnu-zero-variadic-macro-arguments /EHs-c- /GR- -Wno-suggest-override -std:c++17 /showIncludes /Fotools\clang\unittests\Basic\CMakeFiles\BasicTests.dir\DarwinSDKInfoTest.cpp.obj /Fdtools\clang\unittests\Basic\CMakeFiles\BasicTests.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\unittests\Basic\DarwinSDKInfoTest.cpp
C:\_work\llvm-project\llvm-project\clang\unittests\Basic\DarwinSDKInfoTest.cpp(106,72): error: too few arguments to function call, expected 2, have 1
106 |   auto SDKInfo = DarwinSDKInfo::parseDarwinSDKSettingsJSON(&SDKSettings);
|                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~             ^
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/DarwinSDKInfo.h(231,3): note: 'parseDarwinSDKSettingsJSON' declared here
231 |   parseDarwinSDKSettingsJSON(std::string FilePath,
|   ^                          ~~~~~~~~~~~~~~~~~~~~~
232 |                              const llvm::json::Object *Obj);
|                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\unittests\Basic\DarwinSDKInfoTest.cpp(136,64): error: too few arguments to function call, expected 2, have 1
136 |   auto SDKInfo = DarwinSDKInfo::parseDarwinSDKSettingsJSON(&Obj);
|                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~     ^
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/DarwinSDKInfo.h(231,3): note: 'parseDarwinSDKSettingsJSON' declared here
231 |   parseDarwinSDKSettingsJSON(std::string FilePath,
|   ^                          ~~~~~~~~~~~~~~~~~~~~~
232 |                              const llvm::json::Object *Obj);
|                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\unittests\Basic\DarwinSDKInfoTest.cpp(183,64): error: too few arguments to function call, expected 2, have 1
183 |   auto SDKInfo = DarwinSDKInfo::parseDarwinSDKSettingsJSON(&Obj);
|                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~     ^
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/DarwinSDKInfo.h(231,3): note: 'parseDarwinSDKSettingsJSON' declared here
231 |   parseDarwinSDKSettingsJSON(std::string FilePath,
|   ^                          ~~~~~~~~~~~~~~~~~~~~~
232 |                              const llvm::json::Object *Obj);
|                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\unittests\Basic\DarwinSDKInfoTest.cpp(229,62): error: too few arguments to function call, expected 2, have 1
229 |   ASSERT_FALSE(DarwinSDKInfo::parseDarwinSDKSettingsJSON(&Obj));
|                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~     ^
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/gtest.h(1819,52): note: expanded from macro 'ASSERT_FALSE'
1819 | #define ASSERT_FALSE(condition) GTEST_ASSERT_FALSE(condition)
|                                                    ^~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/gtest.h(1800,25): note: expanded from macro 'GTEST_ASSERT_FALSE'
1800 |   GTEST_TEST_BOOLEAN_(!(condition), #condition, true, false, \
|                         ^~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/internal/gtest-internal.h(1493,38): note: expanded from macro 'GTEST_TEST_BOOLEAN_'
1493 |           ::testing::AssertionResult(expression))                     \
|                                      ^~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/DarwinSDKInfo.h(231,3): note: 'parseDarwinSDKSettingsJSON' declared here
231 |   parseDarwinSDKSettingsJSON(std::string FilePath,
|   ^                          ~~~~~~~~~~~~~~~~~~~~~
232 |                              const llvm::json::Object *Obj);
|                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\unittests\Basic\DarwinSDKInfoTest.cpp(231,62): error: too few arguments to function call, expected 2, have 1
231 |   ASSERT_FALSE(DarwinSDKInfo::parseDarwinSDKSettingsJSON(&Obj));
|                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~     ^
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/gtest.h(1819,52): note: expanded from macro 'ASSERT_FALSE'
1819 | #define ASSERT_FALSE(condition) GTEST_ASSERT_FALSE(condition)
|                                                    ^~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/gtest.h(1800,25): note: expanded from macro 'GTEST_ASSERT_FALSE'
1800 |   GTEST_TEST_BOOLEAN_(!(condition), #condition, true, false, \
|                         ^~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/internal/gtest-internal.h(1493,38): note: expanded from macro 'GTEST_TEST_BOOLEAN_'
1493 |           ::testing::AssertionResult(expression))                     \
|                                      ^~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/DarwinSDKInfo.h(231,3): note: 'parseDarwinSDKSettingsJSON' declared here
231 |   parseDarwinSDKSettingsJSON(std::string FilePath,
|   ^                          ~~~~~~~~~~~~~~~~~~~~~
232 |                              const llvm::json::Object *Obj);
|                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/177748