[clang] [LifetimeSafety] Add suggestion and inference for implicit this (PR #176703)

[Utkarsh Saxena via cfe-commits]

================
@@ -60,6 +60,14 @@ class LifetimeSafetyReporter {
   virtual void suggestAnnotation(SuggestionScope Scope,
                                  const ParmVarDecl *ParmToAnnotate,
                                  const Expr *EscapeExpr) {}
+
+  // Suggests lifetime bound annotations for implicit this
+  virtual void suggestAnnotation(SuggestionScope Scope, const CXXMethodDecl *MD,
+                                 const Expr *EscapeExpr) {}
+
+  // Adds inferred lifetime bound attribute for implicit this to its
+  // TypeSourceInfo
+  virtual void addLifetimeBoundToImplicitThis(const CXXMethodDecl *MD) {}
----------------
usx95 wrote:

This most likely belongs to LifetimeAnnotations.cpp. I would minimise the surface of `LifetimeSafetyReporter` as much as possible and only have boiler plate plumbing for diagnostics

https://github.com/llvm/llvm-project/pull/176703