[clang] AMDGPU: Find device files even when ROCM_PATH is set (PR #177346)

[Joseph Huber via cfe-commits]

================
@@ -207,16 +211,15 @@ RocmInstallationDetector::getInstallationPathCandidates() {
 
   // For candidate specified by --rocm-path we do not do strict check, i.e.,
   // checking existence of HIP version file and device library files.
+  // These are added first as highest priority candidates, but we continue
+  // to add clang-relative paths to support cases where the compiler has its
+  // own device libraries (e.g., python wheels with bundled device libs).
----------------
jhuber6 wrote:

The resource directory is the proper place to put these libraries, they're linked to the compiler ABI and we've had loads of issues in the past where we change the default in the compiler and people's ROCm installations are behind. I don't think there's much enthusiasm to move this code however.

https://github.com/llvm/llvm-project/pull/177346