[clang] [llvm] [SystemZ] Global Stackprotector and associated location section (PR #169317)

Dominik Steenken via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 22 04:41:50 PST 2026


================
@@ -5841,6 +5834,14 @@ def mstack_protector_guard_reg_EQ : Joined<["-"], "mstack-protector-guard-reg=">
   Visibility<[ClangOption, CC1Option]>,
   HelpText<"Use the given reg for addressing the stack-protector guard">,
   MarshallingInfoString<CodeGenOpts<"StackProtectorGuardReg">>;
+def mstackprotector_guard_record
+    : Flag<["-"], "mstack-protector-guard-record">,
+      HelpText<
+          "Generate a __stack_protector_loc section entry for each load of "
+          "the stackguard address.">,
----------------
dominik-steenken wrote:

As far as i understood, the `__stack_protector_loc` section is meant to hold the location of each load of the address of the stack-protector guard. Saying
```
          "Generate a __stack_protector_loc section entry for each load of "
          "the stack-protector guard."
```
could be misunderstood as the locations pointing at loads of the stack-protector guard *value*, could it not? Should this say "stack-protector guard address" instead?

https://github.com/llvm/llvm-project/pull/169317


More information about the cfe-commits mailing list