[clang-tools-extra] [clang-tidy] Add a new check 'performance-string-view-conversions' (PR #174288)

Wed Jan 21 10:51:50 PST 2026

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot3` while building `clang-tools-extra` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/19156

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
UBSAN_OPTIONS=print_stacktrace=1
BUILDBOT_GOT_REVISION=9276322fca40f61a7960d17fd2f0fe06c41effb5
LC_ALL=C
JOURNAL_STREAM=9:65174
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/snap/bin
BOT_DIR=/home/b
LIT_OPTS=--time-tests --timeout=900
_=/usr/bin/env
ninja: Entering directory `libcxx_build_asan_ubsan'
[1/6] Building CXX object libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o
FAILED: libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o 
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build0/bin/clang++ -DLIBCXX_BUILDING_LIBCXXABI -DLIBC_NAMESPACE=__llvm_libc_common_utils -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_AVAILABILITY_MINIMUM_HEADER_VERSION=2 -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src -I/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1 -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxxabi/include -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/cmake/Modules/../../libc -fsanitize=address,undefined -fno-sanitize-recover=all   -fno-sanitize=vptr -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -gline-tables-only -fsanitize=address  -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++23 -fPIC -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -fsized-deallocation -Wall -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wzero-length-array -Wdeprecated-redundant-constexpr-static-def -Wno-nullability-completeness -Wmissing-prototypes -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -fdebug-prefix-map=/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1=/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/include -fno-omit-frame-pointer -gline-tables-only -fsanitize=address,undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all -MD -MT libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o -MF libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o.d -o libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o -c /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp:12:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/from_chars_floating_point.h:29:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/to_chars_floating_point.h:30:
/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1/cfloat:81:8: error: "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
   81 | #      error "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
      |        ^
1 error generated.
[2/6] Building CXX object libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o
FAILED: libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o 
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build0/bin/clang++ -DLIBCXX_BUILDING_LIBCXXABI -DLIBC_NAMESPACE=__llvm_libc_common_utils -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_AVAILABILITY_MINIMUM_HEADER_VERSION=2 -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src -I/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1 -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxxabi/include -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/cmake/Modules/../../libc -fsanitize=address,undefined -fno-sanitize-recover=all   -fno-sanitize=vptr -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -gline-tables-only -fsanitize=address  -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++23 -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -fsized-deallocation -Wall -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wzero-length-array -Wdeprecated-redundant-constexpr-static-def -Wno-nullability-completeness -Wmissing-prototypes -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -fdebug-prefix-map=/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1=/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/include -fno-omit-frame-pointer -gline-tables-only -fsanitize=address,undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all -MD -MT libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o -MF libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o.d -o libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o -c /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp:12:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/from_chars_floating_point.h:29:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/to_chars_floating_point.h:30:
/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1/cfloat:81:8: error: "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
   81 | #      error "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
      |        ^
1 error generated.
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild

@@@STEP_FAILURE@@@

@@@STEP_FAILURE@@@

@@@STEP_FAILURE@@@
BUILDBOT_REVISION=771517e9bfae453811f05940d6ac17083b2c907f
MEMORY_PRESSURE_WRITE=c29tZSAyMDAwMDAgMjAwMDAwMAA=
PWD=/home/b/sanitizer-x86_64-linux-fast/build
LOGNAME=buildbot
BUILDBOT_CLOBBER=
BUILDBOT_CLEAN=
SYSTEMD_EXEC_PID=14181
BUILDBOT_BRANCH=main
STAGE2_DIR=llvm_build_asan_ubsan
BUILDBOT_CLEAN_OBJ=True
Step 8 (stage2/asan_ubsan build libcxx) failure: stage2/asan_ubsan build libcxx (failure)
...
UBSAN_OPTIONS=print_stacktrace=1
BUILDBOT_GOT_REVISION=9276322fca40f61a7960d17fd2f0fe06c41effb5
LC_ALL=C
JOURNAL_STREAM=9:65174
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/snap/bin
BOT_DIR=/home/b
LIT_OPTS=--time-tests --timeout=900
_=/usr/bin/env
ninja: Entering directory `libcxx_build_asan_ubsan'
[1/6] Building CXX object libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o
FAILED: libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o 
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build0/bin/clang++ -DLIBCXX_BUILDING_LIBCXXABI -DLIBC_NAMESPACE=__llvm_libc_common_utils -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_AVAILABILITY_MINIMUM_HEADER_VERSION=2 -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src -I/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1 -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxxabi/include -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/cmake/Modules/../../libc -fsanitize=address,undefined -fno-sanitize-recover=all   -fno-sanitize=vptr -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -gline-tables-only -fsanitize=address  -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++23 -fPIC -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -fsized-deallocation -Wall -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wzero-length-array -Wdeprecated-redundant-constexpr-static-def -Wno-nullability-completeness -Wmissing-prototypes -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -fdebug-prefix-map=/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1=/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/include -fno-omit-frame-pointer -gline-tables-only -fsanitize=address,undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all -MD -MT libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o -MF libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o.d -o libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o -c /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp:12:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/from_chars_floating_point.h:29:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/to_chars_floating_point.h:30:
/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1/cfloat:81:8: error: "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
   81 | #      error "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
      |        ^
1 error generated.
[2/6] Building CXX object libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o
FAILED: libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o 
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build0/bin/clang++ -DLIBCXX_BUILDING_LIBCXXABI -DLIBC_NAMESPACE=__llvm_libc_common_utils -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_AVAILABILITY_MINIMUM_HEADER_VERSION=2 -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src -I/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1 -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxxabi/include -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/cmake/Modules/../../libc -fsanitize=address,undefined -fno-sanitize-recover=all   -fno-sanitize=vptr -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -gline-tables-only -fsanitize=address  -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++23 -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -fsized-deallocation -Wall -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wzero-length-array -Wdeprecated-redundant-constexpr-static-def -Wno-nullability-completeness -Wmissing-prototypes -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -fdebug-prefix-map=/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1=/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/include -fno-omit-frame-pointer -gline-tables-only -fsanitize=address,undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all -MD -MT libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o -MF libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o.d -o libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o -c /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp:12:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/from_chars_floating_point.h:29:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/to_chars_floating_point.h:30:
/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan_ubsan/include/c++/v1/cfloat:81:8: error: "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
   81 | #      error "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
      |        ^
1 error generated.
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild

BUILDBOT_REVISION=771517e9bfae453811f05940d6ac17083b2c907f
MEMORY_PRESSURE_WRITE=c29tZSAyMDAwMDAgMjAwMDAwMAA=
PWD=/home/b/sanitizer-x86_64-linux-fast/build
LOGNAME=buildbot
BUILDBOT_CLOBBER=
BUILDBOT_CLEAN=
SYSTEMD_EXEC_PID=14181
BUILDBOT_BRANCH=main
STAGE2_DIR=llvm_build_asan_ubsan
BUILDBOT_CLEAN_OBJ=True
HOME=/home/b
LANG=C.UTF-8
MEMORY_PRESSURE_WATCH=/sys/fs/cgroup/system.slice/system-buildbot\x2dworker.slice/buildbot-worker at b.service/memory.pressure
Step 10 (stage2/asan_ubsan check) failure: stage2/asan_ubsan check (failure)
...
llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:561: note: using lld-link: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/lld-link
llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:561: note: using ld64.lld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:561: note: using wasm-ld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:561: note: using ld.lld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/ld.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:561: note: using lld-link: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/lld-link
llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:561: note: using ld64.lld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:561: note: using wasm-ld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/main.py:74: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 95491 tests, 64 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.
FAIL: LLVM :: ExecutionEngine/JITLink/x86-64/MachO_archive_load_hidden_expect_failure.s (66776 of 95491)
******************** TEST 'LLVM :: ExecutionEngine/JITLink/x86-64/MachO_archive_load_hidden_expect_failure.s' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
rm -rf /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp && mkdir -p /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp
# executed command: rm -rf /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp
# note: command had no output on stdout or stderr
# executed command: mkdir -p /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp
# note: command had no output on stdout or stderr
# RUN: at line 2
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-mc -triple x86_64-apple-macosx10.9 -filetype=obj    -o /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/MachO_extra_def_strong.o /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/Inputs/MachO_extra_def_strong.s
# executed command: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-mc -triple x86_64-apple-macosx10.9 -filetype=obj -o /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/MachO_extra_def_strong.o /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/Inputs/MachO_extra_def_strong.s
# note: command had no output on stdout or stderr
# RUN: at line 4
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-ar crs /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/libExtraDef.a /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/MachO_extra_def_strong.o
# executed command: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-ar crs /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/libExtraDef.a /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/MachO_extra_def_strong.o
# note: command had no output on stdout or stderr
# RUN: at line 5
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-mc -triple x86_64-apple-macosx10.9 -filetype=obj    -o /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/MachO_archive_load_hidden_support.o /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/MachO_archive_load_hidden_expect_failure.s
# executed command: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-mc -triple x86_64-apple-macosx10.9 -filetype=obj -o /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/MachO_archive_load_hidden_support.o /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/MachO_archive_load_hidden_expect_failure.s
# note: command had no output on stdout or stderr
# RUN: at line 7
not /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-jitlink -noexec /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/MachO_archive_load_hidden_support.o -lFoo    -jd Foo -L/home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp -hidden-lExtraDef
# executed command: not /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-jitlink -noexec /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp/MachO_archive_load_hidden_support.o -lFoo -jd Foo -L/home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_archive_load_hidden_expect_failure.s.tmp -hidden-lExtraDef
# .---command stderr------------
# | llvm-jitlink error: Symbols not found: [ ExtraDef ]
# | libc++abi: Pure virtual function called!
# `-----------------------------
# error: command failed with exit status: 1

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Slowest Tests:
--------------------------------------------------------------------------
Step 12 (stage2/msan build libcxx) failure: stage2/msan build libcxx (failure)
...
BUILDBOT_GOT_REVISION=9276322fca40f61a7960d17fd2f0fe06c41effb5
LC_ALL=C
JOURNAL_STREAM=9:65174
MSAN_OPTIONS=log_path=/home/b/sanitizer-x86_64-linux-fast/build/sanitizer_logs/report:log_exe_name=1:abort_on_error=1
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/snap/bin
BOT_DIR=/home/b
LIT_OPTS=--time-tests --timeout=900
_=/usr/bin/env
ninja: Entering directory `libcxx_build_msan'
[1/6] Building CXX object libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o
FAILED: libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o 
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build0/bin/clang++ -DLIBCXX_BUILDING_LIBCXXABI -DLIBC_NAMESPACE=__llvm_libc_common_utils -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_AVAILABILITY_MINIMUM_HEADER_VERSION=2 -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src -I/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1 -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxxabi/include -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/cmake/Modules/../../libc -fsanitize=memory -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -gline-tables-only -fsanitize=memory -fdiagnostics-color -ffunction-sections -fdata-sections -Oz -std=c++23 -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -fsized-deallocation -Wall -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wzero-length-array -Wdeprecated-redundant-constexpr-static-def -Wno-nullability-completeness -Wmissing-prototypes -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -fdebug-prefix-map=/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1=/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/include -fno-omit-frame-pointer -gline-tables-only -fsanitize=memory -MD -MT libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o -MF libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o.d -o libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o -c /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp:12:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/from_chars_floating_point.h:29:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/to_chars_floating_point.h:30:
/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/cfloat:81:8: error: "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
   81 | #      error "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
      |        ^
1 error generated.
[2/6] Building CXX object libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o
FAILED: libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o 
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build0/bin/clang++ -DLIBCXX_BUILDING_LIBCXXABI -DLIBC_NAMESPACE=__llvm_libc_common_utils -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_AVAILABILITY_MINIMUM_HEADER_VERSION=2 -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src -I/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1 -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxxabi/include -I/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/cmake/Modules/../../libc -fsanitize=memory -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -gline-tables-only -fsanitize=memory -fdiagnostics-color -ffunction-sections -fdata-sections -Oz -std=c++23 -fPIC -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -fsized-deallocation -Wall -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wzero-length-array -Wdeprecated-redundant-constexpr-static-def -Wno-nullability-completeness -Wmissing-prototypes -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -fdebug-prefix-map=/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1=/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/include -fno-omit-frame-pointer -gline-tables-only -fsanitize=memory -MD -MT libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o -MF libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o.d -o libcxx/src/CMakeFiles/cxx_shared.dir/charconv.cpp.o -c /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/charconv.cpp:12:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/from_chars_floating_point.h:29:
In file included from /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/libcxx/src/include/to_chars_floating_point.h:30:
/home/b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/cfloat:81:8: error: "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
   81 | #      error "If libc++ starts defining <float.h>, the __has_include check should move to libc++'s <float.h>"
      |        ^
1 error generated.
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild

BUILDBOT_REVISION=771517e9bfae453811f05940d6ac17083b2c907f
MSAN_SYMBOLIZER_PATH=/home/b/sanitizer-x86_64-linux-fast/build/llvm_build0/bin/llvm-symbolizer
MEMORY_PRESSURE_WRITE=c29tZSAyMDAwMDAgMjAwMDAwMAA=
PWD=/home/b/sanitizer-x86_64-linux-fast/build
LOGNAME=buildbot
BUILDBOT_CLOBBER=
BUILDBOT_CLEAN=
SYSTEMD_EXEC_PID=14181
BUILDBOT_BRANCH=main
STAGE2_DIR=llvm_build_msan
BUILDBOT_CLEAN_OBJ=True
HOME=/home/b
LANG=C.UTF-8

```

</details>

https://github.com/llvm/llvm-project/pull/174288