[clang] [LifetimeSafety] Add suggestion and inference for implicit this (PR #176703)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 51872 tests passed
* 911 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.Sema/warn-lifetime-safety-suggestions.cpp</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
rm -rf C:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp
# executed command: rm -rf 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp'
# note: command had no output on stdout or stderr
# RUN: at line 2
split-file C:\_work\llvm-project\llvm-project\clang\test\Sema\warn-lifetime-safety-suggestions.cpp C:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp
# executed command: split-file 'C:\_work\llvm-project\llvm-project\clang\test\Sema\warn-lifetime-safety-suggestions.cpp' 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp'
# note: command had no output on stdout or stderr
# RUN: at line 3
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -cc1 -internal-isystem C:\_work\llvm-project\llvm-project\build\lib\clang\23\include -nostdsysteminc -fsyntax-only -fexperimental-lifetime-safety -fexperimental-lifetime-safety-inference -fexperimental-lifetime-safety-tu-analysis -Wexperimental-lifetime-safety-suggestions -Wexperimental-lifetime-safety -Wno-dangling -IC:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp -verify C:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp/test_source.cpp
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -cc1 -internal-isystem 'C:\_work\llvm-project\llvm-project\build\lib\clang\23\include' -nostdsysteminc -fsyntax-only -fexperimental-lifetime-safety -fexperimental-lifetime-safety-inference -fexperimental-lifetime-safety-tu-analysis -Wexperimental-lifetime-safety-suggestions -Wexperimental-lifetime-safety -Wno-dangling '-IC:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp' -verify 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp/test_source.cpp'
# .---command stderr------------
# | error: 'expected-warning' diagnostics seen but not expected: 
# |   File C:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp/test_source.cpp Line 130: implict this in intra-TU function should be marked [[clang::lifetimebound]]
# | error: 'expected-note' diagnostics seen but not expected: 
# |   File C:\_work\llvm-project\llvm-project\build\tools\clang\test\Sema\Output\warn-lifetime-safety-suggestions.cpp.tmp/test_source.cpp Line 131: param returned here
# | 2 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/176703