[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

Aditi Medhane via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 20 00:57:50 PST 2026


================
@@ -11224,6 +11224,10 @@ def err_ppc_invalid_use_mma_type : Error<
   "invalid use of PPC MMA type">;
 def err_ppc_invalid_test_data_class_type : Error<
   "expected a 'float', 'double' or '__float128' for the first argument">;
+def err_ppc_invalid_vector_type : Error<
+  "argument %0 must be of type %1">;
+def err_ppc_invalid_integer_type : Error<
+  "argument %0 must be of %1">;
----------------
AditiRM wrote:

i think we need two diagnostics for clarity. vector args use a concrete clang type, so "argument %0 must be of type %1" formats correctly (e.g.` __vector unsigned char`). integer args use a type category (`"integer type"`), and using the same wording results in awkward output like `of type integer type`. keeping separate diagnostics preserves correct grammar and clearer user-facing errors.

https://github.com/llvm/llvm-project/pull/154715


More information about the cfe-commits mailing list