[clang-tools-extra] [clang-tidy] Warn on use of std::get_temporary_buffer (PR #176191)

[Donát Nagy via cfe-commits]

================
@@ -97,6 +98,9 @@ static StringRef getRationaleFor(StringRef FunctionName) {
       .Cases({"rewind", "setbuf"}, "has no error detection")
       .Case("vfork", "is insecure as it can lead to denial of service "
                      "situations in the parent process")
+      .Case("get_temporary_buffer",
+            "is bugprone, has no performance advantage, was deprecated in "
+            "C++17 and removed in C++20")
----------------
NagyDonat wrote:

Thanks, that's a great way to express the problem concisely. I applied it in https://github.com/llvm/llvm-project/pull/176191/commits/bc03b04b44c834a80a75b5affd1e66a6647f4b5f

https://github.com/llvm/llvm-project/pull/176191