[clang] Stop calling a constexpr function to evaluate the boolean condition of (PR #176241)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Akira Hatanaka (ahatanak)

<details>
<summary>Changes</summary>

std::enable_if

This is an attempt to fix a windows build failure after 6fac9b143252bec62c1a5ee9fc1b0f214e7f2f8e.

---
Full diff: https://github.com/llvm/llvm-project/pull/176241.diff


1 Files Affected:

- (modified) clang/lib/AST/AttrImpl.cpp (+7-8) 


``````````diff
diff --git a/clang/lib/AST/AttrImpl.cpp b/clang/lib/AST/AttrImpl.cpp
index 3d994e06d2342..0c7e81f1749cb 100644
--- a/clang/lib/AST/AttrImpl.cpp
+++ b/clang/lib/AST/AttrImpl.cpp
@@ -289,21 +289,20 @@ namespace {
 //  - DeclArgument
 //  - OMPTraitInfoArgument
 //  - VariadicOMPInteropInfoArgument
-template <class T> constexpr bool useDefaultEquality() {
-  return std::is_same_v<T, StringRef> || std::is_same_v<T, VersionTuple> ||
-         std::is_same_v<T, IdentifierInfo *> || std::is_same_v<T, ParamIdx> ||
-         std::is_same_v<T, Attr *> || std::is_same_v<T, char *> ||
-         std::is_enum_v<T> || std::is_integral_v<T>;
-}
+#define USE_DEFAULT_EQUALITY                                                   \
+  (std::is_same_v<T, StringRef> || std::is_same_v<T, VersionTuple> ||          \
+   std::is_same_v<T, IdentifierInfo *> || std::is_same_v<T, ParamIdx> ||       \
+   std::is_same_v<T, Attr *> || std::is_same_v<T, char *> ||                   \
+   std::is_enum_v<T> || std::is_integral_v<T>)
 
 template <class T>
-typename std::enable_if_t<!useDefaultEquality<T>(), bool>
+typename std::enable_if_t<!USE_DEFAULT_EQUALITY, bool>
 equalAttrArgs(T A, T B, StructuralEquivalenceContext &Context) {
   return false;
 }
 
 template <class T>
-typename std::enable_if_t<useDefaultEquality<T>(), bool>
+typename std::enable_if_t<USE_DEFAULT_EQUALITY, bool>
 equalAttrArgs(T A1, T A2, StructuralEquivalenceContext &Context) {
   return A1 == A2;
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/176241