[clang] [llvm] [analyzer] New checker: optin.core.UnconditionalVAArg (PR #175602)

[Arseniy Zaostrovnykh via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/175602 at github.com>


================
@@ -122,13 +125,14 @@ void UnconditionalVAArgChecker::checkBranchCondition(const Stmt *Condition,
 void UnconditionalVAArgChecker::checkPreStmt(const VAArgExpr *VAA,
                                              CheckerContext &C) const {
   ProgramStateRef State = C.getState();
-  const FunctionDecl *FD = getCurrentFunction(C);
-  if (FD && FD == State->get<HasUnconditionalPath>()) {
+  const FunctionDecl *PathFrom =
+      State->get<HasUnconditionalPath>(); // getCurrentFunction(C);
----------------
necto wrote:

Is this comment an undeleted left over? Otherwise, I fail to understand it.

https://github.com/llvm/llvm-project/pull/175602