[clang] [llvm] Enable fexec-charset option (PR #138895)

Sergei Barannikov via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 10 17:14:22 PST 2026


================
@@ -135,6 +135,9 @@ class TextEncodingConverter {
       return std::string(Result);
     return EC;
   }
+
+  // Maps the encoding name to enum constant if possible.
----------------
s-barannikov wrote:

This looks like exposing an implementation detail. Should we instead add a method checking if the conversion is supported?

---
The comment should be doxygen-style (///).

https://github.com/llvm/llvm-project/pull/138895


More information about the cfe-commits mailing list