[clang-tools-extra] [clang-tidy] Add a new check 'performance-string-view-conversions' (PR #174288)

via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 7 10:09:24 PST 2026 

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=4294967295] tools/clang/tools/extra/clangd/benchmarks/IndexBenchmark.exe</summary>

```
FAILED: [code=4294967295] tools/clang/tools/extra/clangd/benchmarks/IndexBenchmark.exe
cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --intdir=tools\clang\tools\extra\clangd\benchmarks\CMakeFiles\IndexBenchmark.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\IndexBenchmark.rsp  /out:tools\clang\tools\extra\clangd\benchmarks\IndexBenchmark.exe /implib:tools\clang\tools\extra\clangd\benchmarks\IndexBenchmark.lib /pdb:tools\clang\tools\extra\clangd\benchmarks\IndexBenchmark.pdb /version:0.0 /MANIFEST:NO /STACK:10000000 /INCREMENTAL:NO /subsystem:console  && cd ."
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\IndexBenchmark.rsp /out:tools\clang\tools\extra\clangd\benchmarks\IndexBenchmark.exe /implib:tools\clang\tools\extra\clangd\benchmarks\IndexBenchmark.lib /pdb:tools\clang\tools\extra\clangd\benchmarks\IndexBenchmark.pdb /version:0.0 /MANIFEST:NO /STACK:10000000 /INCREMENTAL:NO /subsystem:console" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: public: static unsigned int __cdecl llvm::OpenMPIRBuilder::getOpenMPDefaultSimdAlign(class llvm::Triple const &, class llvm::StringMap<bool, class llvm::MallocAllocator> const &)
>>> referenced by clangAST.lib(ASTContext.cpp.obj):(public: unsigned int __cdecl clang::ASTContext::getOpenMPDefaultSimdAlign(class clang::QualType) const)

lld-link: error: undefined symbol: class llvm::StringRef __cdecl llvm::omp::getOpenMPDirectiveName(enum llvm::omp::Directive, unsigned int)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPIfClause(class clang::OMPIfClause *))
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPAbsentClause(class clang::OMPAbsentClause *))
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPAbsentClause(class clang::OMPAbsentClause *))
>>> referenced 73 more times

lld-link: error: undefined symbol: class llvm::StringRef __cdecl llvm::omp::getOpenMPClauseName(enum llvm::omp::Clause, unsigned int)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(private: void __cdecl clang::OMPClausePrinter::VisitOMPMotionClause<class clang::OMPToClause>(class clang::OMPToClause *))
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(private: void __cdecl clang::OMPClausePrinter::VisitOMPMotionClause<class clang::OMPFromClause>(class clang::OMPFromClause *))
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(char const * __cdecl clang::getOpenMPSimpleClauseTypeName(enum llvm::omp::Clause, unsigned int))
>>> referenced 72 more times

lld-link: error: undefined symbol: enum llvm::omp::TraitSet __cdecl llvm::omp::getOpenMPContextTraitSetForProperty(enum llvm::omp::TraitProperty)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::getAsVariantMatchInfo(class clang::ASTContext &, struct llvm::omp::VariantMatchInfo &) const)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::getAsVariantMatchInfo(class clang::ASTContext &, struct llvm::omp::VariantMatchInfo &) const)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::getAsVariantMatchInfo(class clang::ASTContext &, struct llvm::omp::VariantMatchInfo &) const)
>>> referenced 1 more times

lld-link: error: undefined symbol: enum llvm::omp::TraitProperty __cdecl llvm::omp::getOpenMPContextTraitPropertyForSelector(enum llvm::omp::TraitSelector)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::getAsVariantMatchInfo(class clang::ASTContext &, struct llvm::omp::VariantMatchInfo &) const)

lld-link: error: undefined symbol: class llvm::StringRef __cdecl llvm::omp::getOpenMPContextTraitSetName(enum llvm::omp::TraitSet)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::print(class llvm::raw_ostream &, struct clang::PrintingPolicy const &) const)

lld-link: error: undefined symbol: class llvm::StringRef __cdecl llvm::omp::getOpenMPContextTraitSelectorName(enum llvm::omp::TraitSelector)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::print(class llvm::raw_ostream &, struct clang::PrintingPolicy const &) const)

lld-link: error: undefined symbol: bool __cdecl llvm::omp::isValidTraitSelectorForTraitSet(enum llvm::omp::TraitSelector, enum llvm::omp::TraitSet, bool &, bool &)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::print(class llvm::raw_ostream &, struct clang::PrintingPolicy const &) const)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl clang::OMPTraitInfo::getMangledName(void) const)

lld-link: error: undefined symbol: class llvm::StringRef __cdecl llvm::omp::getOpenMPContextTraitPropertyName(enum llvm::omp::TraitProperty, class llvm::StringRef)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::print(class llvm::raw_ostream &, struct clang::PrintingPolicy const &) const)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPTraitInfo::print(class llvm::raw_ostream &, struct clang::PrintingPolicy const &) const)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl clang::OMPTraitInfo::getMangledName(void) const)

lld-link: error: undefined symbol: enum llvm::omp::TraitProperty __cdecl llvm::omp::getOpenMPContextTraitPropertyKind(enum llvm::omp::TraitSet, enum llvm::omp::TraitSelector, class llvm::StringRef)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: __cdecl clang::OMPTraitInfo::OMPTraitInfo(class llvm::StringRef))

lld-link: error: undefined symbol: public: __cdecl llvm::omp::OMPContext::OMPContext(bool, class llvm::Triple, class llvm::Triple, int)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: __cdecl clang::TargetOMPContext::TargetOMPContext(class clang::ASTContext &, class std::function<void __cdecl(class llvm::StringRef)> &&, class clang::FunctionDecl const *, class llvm::ArrayRef<enum llvm::omp::TraitProperty>, int))

lld-link: error: undefined symbol: enum llvm::omp::Association __cdecl llvm::omp::getDirectiveAssociation(enum llvm::omp::Directive)
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(bool __cdecl clang::isOpenMPLoopDirective(enum llvm::omp::Directive))
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(bool __cdecl clang::isOpenMPSimdDirective(enum llvm::omp::Directive))

lld-link: error: undefined symbol: class llvm::ArrayRef<enum llvm::omp::Directive> __cdecl llvm::omp::getLeafConstructs(enum llvm::omp::Directive)
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(bool __cdecl clang::isOpenMPTaskLoopDirective(enum llvm::omp::Directive))
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(bool __cdecl clang::isOpenMPParallelDirective(enum llvm::omp::Directive))
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(bool __cdecl clang::isOpenMPTargetExecutionDirective(enum llvm::omp::Directive))
>>> referenced 8 more times

lld-link: error: undefined symbol: enum llvm::omp::Category __cdecl llvm::omp::getDirectiveCategory(enum llvm::omp::Directive)
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(bool __cdecl clang::isOpenMPExecutableDirective(enum llvm::omp::Directive))
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(bool __cdecl clang::isOpenMPInformationalDirective(enum llvm::omp::Directive))
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(bool __cdecl clang::isOpenMPCapturingDirective(enum llvm::omp::Directive))

lld-link: error: undefined symbol: class llvm::ArrayRef<enum llvm::omp::Directive> __cdecl llvm::omp::getLeafConstructsOrSelf(enum llvm::omp::Directive)
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(void __cdecl clang::getOpenMPCaptureRegions(class llvm::SmallVectorImpl<enum llvm::omp::Directive> &, enum llvm::omp::Directive))
>>> referenced by clangSema.lib(SemaOpenMP.cpp.obj):(public: class clang::ActionResult<class clang::Stmt *, 1> __cdecl clang::SemaOpenMP::ActOnOpenMPExecutableDirective(enum llvm::omp::Directive, struct clang::DeclarationNameInfo const &, enum llvm::omp::Directive, class llvm::ArrayRef<class clang::OMPClause *>, class clang::Stmt *, class clang::SourceLocation, class clang::SourceLocation))
>>> referenced by clangSema.lib(SemaOpenMP.cpp.obj):(public: class clang::ActionResult<class clang::Stmt *, 1> __cdecl clang::SemaOpenMP::ActOnOpenMPExecutableDirective(enum llvm::omp::Directive, struct clang::DeclarationNameInfo const &, enum llvm::omp::Directive, class llvm::ArrayRef<class clang::OMPClause *>, class clang::Stmt *, class clang::SourceLocation, class clang::SourceLocation))
>>> referenced 5 more times

lld-link: error: undefined symbol: bool __cdecl llvm::omp::isLeafConstruct(enum llvm::omp::Directive)
>>> referenced by clangBasic.lib(OpenMPKinds.cpp.obj):(void __cdecl clang::getOpenMPCaptureRegions(class llvm::SmallVectorImpl<enum llvm::omp::Directive> &, enum llvm::omp::Directive))

lld-link: error: undefined symbol: class llvm::ArrayRef<enum llvm::omp::Directive> __cdecl llvm::omp::getLeafOrCompositeConstructs(enum llvm::omp::Directive, class llvm::SmallVectorImpl<enum llvm::omp::Directive> &)
>>> referenced by clangSema.lib(SemaOpenMP.cpp.obj):(public: class clang::ActionResult<class clang::Stmt *, 1> __cdecl clang::SemaOpenMP::ActOnOpenMPExecutableDirective(enum llvm::omp::Directive, struct clang::DeclarationNameInfo const &, enum llvm::omp::Directive, class llvm::ArrayRef<class clang::OMPClause *>, class clang::Stmt *, class clang::SourceLocation, class clang::SourceLocation))

lld-link: error: undefined symbol: bool __cdecl llvm::omp::isAllowedClauseForDirective(enum llvm::omp::Directive, enum llvm::omp::Clause, unsigned int)
>>> referenced by clangSema.lib(SemaOpenMP.cpp.obj):(public: class clang::ActionResult<class clang::Stmt *, 1> __cdecl clang::SemaOpenMP::ActOnOpenMPExecutableDirective(enum llvm::omp::Directive, struct clang::DeclarationNameInfo const &, enum llvm::omp::Directive, class llvm::ArrayRef<class clang::OMPClause *>, class clang::Stmt *, class clang::SourceLocation, class clang::SourceLocation))
>>> referenced by clangSema.lib(SemaOpenMP.cpp.obj):(public: class clang::OMPClause * __cdecl clang::SemaOpenMP::ActOnOpenMPFilterClause(class clang::Expr *, class clang::SourceLocation, class clang::SourceLocation, class clang::SourceLocation))
>>> referenced by clangSema.lib(SemaOpenMP.cpp.obj):(enum llvm::omp::Directive __cdecl getOpenMPCaptureRegionForClause(enum llvm::omp::Directive, enum llvm::omp::Clause, unsigned int, enum llvm::omp::Directive))
>>> referenced 2 more times

lld-link: error: undefined symbol: bool __cdecl llvm::omp::isVariantApplicableInContext(struct llvm::omp::VariantMatchInfo const &, struct llvm::omp::OMPContext const &, bool)
>>> referenced by clangSema.lib(SemaOpenMP.cpp.obj):(public: class clang::ActionResult<class clang::Expr *, 1> __cdecl clang::SemaOpenMP::ActOnOpenMPCall(class clang::ActionResult<class clang::Expr *, 1>, class clang::Scope *, class clang::SourceLocation, class llvm::MutableArrayRef<class clang::Expr *>, class clang::SourceLocation, class clang::Expr *))

lld-link: error: undefined symbol: int __cdecl llvm::omp::getBestVariantMatchForContext(class llvm::SmallVectorImpl<struct llvm::omp::VariantMatchInfo> const &, struct llvm::omp::OMPContext const &)
>>> referenced by clangSema.lib(SemaOpenMP.cpp.obj):(public: class clang::ActionResult<class clang::Expr *, 1> __cdecl clang::SemaOpenMP::ActOnOpenMPCall(class clang::ActionResult<class clang::Expr *, 1>, class clang::Scope *, class clang::SourceLocation, class llvm::MutableArrayRef<class clang::Expr *>, class clang::SourceLocation, class clang::Expr *))
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/174288

More information about the cfe-commits mailing list