[clang] [Clang] Remove 't' from __builtin_amdgcn_global_atomic_fmin/fmax_f64 (PR #173969)

[via cfe-commits]

Juan Manuel Martinez =?utf-8?q?Caamaño?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/173969 at github.com>


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-amdgpu

Author: Juan Manuel Martinez Caamaño (jmmartinez)

<details>
<summary>Changes</summary>

Allows for type checking depending on the built-in signature.

There is no `f32` version for both builtins.

---
Full diff: https://github.com/llvm/llvm-project/pull/173969.diff


3 Files Affected:

- (modified) clang/include/clang/Basic/BuiltinsAMDGPU.def (+2-2) 
- (added) clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip (+22) 
- (added) clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip (+22) 


``````````diff
diff --git a/clang/include/clang/Basic/BuiltinsAMDGPU.def b/clang/include/clang/Basic/BuiltinsAMDGPU.def
index c4eb91af7933f..37bc4738302b7 100644
--- a/clang/include/clang/Basic/BuiltinsAMDGPU.def
+++ b/clang/include/clang/Basic/BuiltinsAMDGPU.def
@@ -269,8 +269,8 @@ TARGET_BUILTIN(__builtin_amdgcn_fmed3h, "hhhh", "nc", "gfx9-insts")
 TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f64, "dd*1d", "", "gfx90a-insts")
 TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1f", "", "atomic-fadd-rtn-insts")
 TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2f16, "V2hV2h*1V2h", "t", "atomic-buffer-global-pk-add-f16-insts")
-TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fmin_f64, "dd*1d", "t", "gfx90a-insts")
-TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fmax_f64, "dd*1d", "t", "gfx90a-insts")
+TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fmin_f64, "dd*1d", "", "gfx90a-insts")
+TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fmax_f64, "dd*1d", "", "gfx90a-insts")
 
 TARGET_BUILTIN(__builtin_amdgcn_flat_atomic_fadd_f64, "dd*0d", "", "gfx90a-insts")
 TARGET_BUILTIN(__builtin_amdgcn_flat_atomic_fmin_f64, "dd*0d", "", "gfx90a-insts")
diff --git a/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip b/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip
new file mode 100644
index 0000000000000..f04c6e3221bcd
--- /dev/null
+++ b/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip
@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -fsyntax-only -triple amdgcn -target-cpu gfx942 -verify %s -fcuda-is-device
+// RUN: %clang_cc1 -fsyntax-only -triple x86_64 -aux-triple amdgcn -verify %s
+
+#define __device__ __attribute__((device))
+#define __shared__ __attribute__((shared))
+
+__device__ double global_double;
+
+__device__ void test_global_atomic_fmax_f64_valid(double *ptr, double val) {
+  double result;
+  result = __builtin_amdgcn_global_atomic_fmax_f64(ptr, val);
+  result = __builtin_amdgcn_global_atomic_fmax_f64(&global_double, val);
+}
+
+__device__ void test_global_atomic_fmax_f64_errors(double *ptr, double val,
+                                                   __shared__ double *lds_ptr,
+                                                   float *ptr_f) {
+  double result;
+  result = __builtin_amdgcn_global_atomic_fmax_f64(ptr, val, 0); // expected-error{{too many arguments to function call, expected 2, have 3}}
+  result = __builtin_amdgcn_global_atomic_fmax_f64(lds_ptr, val);
+  result = __builtin_amdgcn_global_atomic_fmax_f64(ptr_f, val); // expected-error{{cannot initialize a parameter of type}}
+}
diff --git a/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip b/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip
new file mode 100644
index 0000000000000..3a63d513113b4
--- /dev/null
+++ b/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip
@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -fsyntax-only -triple amdgcn -target-cpu gfx942 -verify %s -fcuda-is-device
+// RUN: %clang_cc1 -fsyntax-only -triple x86_64 -aux-triple amdgcn -verify %s
+
+#define __device__ __attribute__((device))
+#define __shared__ __attribute__((shared))
+
+__device__ double global_double;
+
+__device__ void test_global_atomic_fmin_f64_valid(double *ptr, double val) {
+  double result;
+  result = __builtin_amdgcn_global_atomic_fmin_f64(ptr, val);
+  result = __builtin_amdgcn_global_atomic_fmin_f64(&global_double, val);
+}
+
+__device__ void test_global_atomic_fmin_f64_errors(double *ptr, double val,
+                                                   __shared__ double *lds_ptr,
+                                                   float *ptr_f) {
+  double result;
+  result = __builtin_amdgcn_global_atomic_fmin_f64(ptr, val, 0); // expected-error{{too many arguments to function call, expected 2, have 3}}
+  result = __builtin_amdgcn_global_atomic_fmin_f64(lds_ptr, val);
+  result = __builtin_amdgcn_global_atomic_fmin_f64(ptr_f, val); // expected-error{{cannot initialize a parameter of type}}
+}

``````````

</details>


https://github.com/llvm/llvm-project/pull/173969