[clang-tools-extra] [clang-tidy][NFC] Devirtualize `GlobList` and don't heap allocate it (PR #164212)

Victor Chernyakin via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 28 03:57:24 PST 2025


================
@@ -24,7 +24,7 @@ namespace clang::tidy {
 /// them in the order of appearance in the list.
 class GlobList {
 public:
-  virtual ~GlobList() = default;
+  GlobList() = default;
----------------
localspook wrote:

Yeah, if downstream users depend on `GlobList` being polymorphic, I can see how this could be a nasty silent break for them. In that case, closing.

https://github.com/llvm/llvm-project/pull/164212


More information about the cfe-commits mailing list