[clang] [clang] Remove pointless `hasDiagnostics()` checks (PR #172705)

[Qiongsi Wu via cfe-commits]

qiongsiwu wrote:

Ah thanks for catching this! 

Is it also OK to remove the check for these cases?
https://github.com/llvm/llvm-project/blob/7f1a30ebd242b2a55e8393717f1e594f9cd61569/clang/lib/Interpreter/Interpreter.cpp#L115
https://github.com/llvm/llvm-project/blob/7f1a30ebd242b2a55e8393717f1e594f9cd61569/clang/tools/clang-installapi/ClangInstallAPI.cpp#L120
https://github.com/llvm/llvm-project/blob/7f1a30ebd242b2a55e8393717f1e594f9cd61569/clang/tools/driver/cc1_main.cpp#L285


https://github.com/llvm/llvm-project/pull/172705