[clang-tools-extra] [clang-tidy] Add a new check 'replace-with-string-view' (PR #172170)

[Yanzuo Liu via cfe-commits]

================
@@ -0,0 +1,74 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "ReplaceWithStringViewCheck.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::performance {
+
+static llvm::StringLiteral toStringViewTypeStr(StringRef Type) {
----------------
zwuis wrote:

I'm not sure if we should use `StringRef`.

https://github.com/llvm/llvm-project/blob/f2d48dd15b2ec4781222dfb206719acaec3689fd/llvm/include/llvm/ADT/StringRef.h#L849-L850

https://github.com/llvm/llvm-project/pull/172170