[clang-tools-extra] [clang-tidy][NFC] Devirtualize `GlobList` and don't heap allocate it (PR #164212)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE LINT COMMENT: clang-tidy-->


:warning: C/C++ code linter, clang-tidy found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

```bash

git diff -U0 origin/main...HEAD -- clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h clang-tools-extra/clang-tidy/GlobList.h clang-tools-extra/clang-tidy/NoLintDirectiveHandler.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py   -path build -p1 -quiet
```

</details>

<details>
<summary>
View the output from clang-tidy here.
</summary>

```



clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:161:19: error: call to implicitly-deleted default constructor of 'CachedGlobList' [clang-diagnostic-error]
  161 | ClangTidyContext::ClangTidyContext(
      |                   ^
clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:246:18: note: default constructed field 'CheckFilter' declared here
  246 |   CachedGlobList CheckFilter;
      |                  ^
clang-tools-extra/clang-tidy/GlobList.h:55:24: note: default constructor of 'CachedGlobList' is implicitly deleted because base class 'GlobList' has no default constructor
   55 | class CachedGlobList : public GlobList {
      |                        ^
```

</details>


https://github.com/llvm/llvm-project/pull/164212