[clang] [clang][deps] Prefer `DiagnosticConsumer` over `llvm::{Error,Expected}` (PR #172389)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 48541 tests passed
* 845 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### Clang-Unit
<details>
<summary>Clang-Unit._/AllClangUnitTests_exe/DependencyScanner/ScanDepsWithModuleLookup</summary>

```
Script:
--
C:\_work\llvm-project\llvm-project\build\tools\clang\unittests\.\AllClangUnitTests.exe --gtest_filter=DependencyScanner.ScanDepsWithModuleLookup
--
C:\_work\llvm-project\llvm-project\clang\unittests\Tooling\DependencyScannerTest.cpp:301
Value of: DepFile.has_value()
  Actual: true
Expected: false


```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/172389