[clang-tools-extra] readability-identifier-naming should add universal default options (PR #171686)

[Dominik Kaszewski via cfe-commits]

================
@@ -0,0 +1,72 @@
+// RUN: %check_clang_tidy %s readability-identifier-naming %t -- \
+// RUN:   -config='{CheckOptions: { \
+// RUN:     readability-identifier-naming.DefaultCase: "lower_case", \
+// RUN:   }}' \
+// RUN:   -- -fno-delayed-template-parsing
+
+// DefaultCase enables every type of identifier to be checked with same case
+#define MyMacro
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: invalid case style for default 'MyMacro' [readability-identifier-naming]
+// CHECK-FIXES: #define my_macro
+
+namespace MyNamespace {
+// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: invalid case style for default 'MyNamespace' [readability-identifier-naming]
----------------
dkaszews wrote:

The name used in warning is currently tied directly to the name used in options. So that would require changing the `DefaultCase` to `IdentifierCase` or `SymbolCase`, which I find less intuitive to configure.

I still agree that your wording sounds better, so if you are fine with breaking the warning-config correspondence, I can try adding a special case for it.

https://github.com/llvm/llvm-project/pull/171686