[clang] [Matrix] Add a row\col major toggle in the clang driver (PR #167628)

Tue Dec 9 11:58:01 PST 2025

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/LangOptions.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/LangOptions.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\clang\lib\Basic -IC:\_work\llvm-project\llvm-project\clang\lib\Basic -IC:\_work\llvm-project\llvm-project\clang\include -Itools\clang\include -Iinclude -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\clang\lib\Basic\CMakeFiles\obj.clangBasic.dir\LangOptions.cpp.obj /Fdtools\clang\lib\Basic\CMakeFiles\obj.clangBasic.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\Basic\LangOptions.cpp
In file included from C:\_work\llvm-project\llvm-project\clang\lib\Basic\LangOptions.cpp:23:
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/LangOptions.def(437,64): error: use of undeclared identifier 'MatrixColMajor'
437 | ENUM_LANGOPT(DefaultMatrixMemoryLayout, MatrixMemoryLayout, 1, MatrixColMajor, NotCompatible, "Defines the default memory Layout for matrices")
|                                                                ^~~~~~~~~~~~~~
In file included from C:\_work\llvm-project\llvm-project\clang\lib\Basic\LangOptions.cpp:33:
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/LangOptions.def(437,64): error: use of undeclared identifier 'MatrixColMajor'
437 | ENUM_LANGOPT(DefaultMatrixMemoryLayout, MatrixMemoryLayout, 1, MatrixColMajor, NotCompatible, "Defines the default memory Layout for matrices")
|                                                                ^~~~~~~~~~~~~~
2 errors generated.
```
</details>
<details>
<summary>[code=1] tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaChecking.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaChecking.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\clang\lib\Sema -IC:\_work\llvm-project\llvm-project\clang\lib\Sema -IC:\_work\llvm-project\llvm-project\clang\include -Itools\clang\include -Iinclude -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\clang\lib\Sema\CMakeFiles\obj.clangSema.dir\SemaChecking.cpp.obj /Fdtools\clang\lib\Sema\CMakeFiles\obj.clangSema.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\Sema\SemaChecking.cpp
C:\_work\llvm-project\llvm-project\clang\lib\Sema\SemaChecking.cpp(16515,20): error: no member named 'MatrixColMajor' in 'clang::LangOptions'
16515 |       LangOptions::MatrixColMajor) {
|                    ^~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\lib\Sema\SemaChecking.cpp(16639,20): error: no member named 'MatrixColMajor' in 'clang::LangOptions'
16639 |       LangOptions::MatrixColMajor) {
|                    ^~~~~~~~~~~~~~
2 errors generated.
```
</details>
<details>
<summary>[code=1] tools/clang/lib/Frontend/CMakeFiles/obj.clangFrontend.dir/CompilerInvocation.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/lib/Frontend/CMakeFiles/obj.clangFrontend.dir/CompilerInvocation.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\clang\lib\Frontend -IC:\_work\llvm-project\llvm-project\clang\lib\Frontend -IC:\_work\llvm-project\llvm-project\clang\include -Itools\clang\include -Iinclude -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\CompilerInvocation.cpp.obj /Fdtools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\Frontend\CompilerInvocation.cpp
C:\_work\llvm-project\llvm-project\clang\lib\Frontend\CompilerInvocation.cpp(3956,56): error: no member named 'MatrixColMajor' in 'clang::LangOptions'
3956 |     if (Opts.DefaultMatrixMemoryLayout == LangOptions::MatrixColMajor)
|                                                        ^~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\lib\Frontend\CompilerInvocation.cpp(3958,56): error: no member named 'MatrixRowMajor' in 'clang::LangOptions'
3958 |     if (Opts.DefaultMatrixMemoryLayout == LangOptions::MatrixRowMajor)
|                                                        ^~~~~~~~~~~~~~
2 errors generated.
```
</details>
<details>
<summary>[code=1] tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Frontend/CompilerInvocationTest.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Frontend/CompilerInvocationTest.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\clang\unittests -IC:\_work\llvm-project\llvm-project\clang\unittests -IC:\_work\llvm-project\llvm-project\clang\include -Itools\clang\include -Iinclude -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\clang\unittests\Tooling -IC:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -MD  -Wno-gnu-zero-variadic-macro-arguments /EHs-c- /GR- -UNDEBUG -Wno-suggest-override -std:c++17 /showIncludes /Fotools\clang\unittests\CMakeFiles\AllClangUnitTests.dir\Frontend\CompilerInvocationTest.cpp.obj /Fdtools\clang\unittests\CMakeFiles\AllClangUnitTests.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\unittests\Frontend\CompilerInvocationTest.cpp
C:\_work\llvm-project\llvm-project\clang\unittests\Frontend\CompilerInvocationTest.cpp(742,26): error: no member named 'MatrixColMajor' in 'clang::LangOptions'
742 |             LangOptions::MatrixColMajor);
|                          ^~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\unittests\Frontend\CompilerInvocationTest.cpp(752,26): error: no member named 'MatrixRowMajor' in 'clang::LangOptions'
752 |             LangOptions::MatrixRowMajor);
|                          ^~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\unittests\Frontend\CompilerInvocationTest.cpp(764,26): error: no member named 'MatrixColMajor' in 'clang::LangOptions'
764 |             LangOptions::MatrixColMajor);
|                          ^~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\unittests\Frontend\CompilerInvocationTest.cpp(775,26): error: no member named 'MatrixRowMajor' in 'clang::LangOptions'
775 |             LangOptions::MatrixRowMajor);
|                          ^~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\unittests\Frontend\CompilerInvocationTest.cpp(786,26): error: no member named 'MatrixColMajor' in 'clang::LangOptions'
786 |             LangOptions::MatrixColMajor);
|                          ^~~~~~~~~~~~~~
5 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/167628