[clang-tools-extra] 1226a6d - [clang-tidy] Fix fragile test in `read-parameters-from-file` (#171033)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Dec 7 05:24:01 PST 2025
Author: mitchell
Date: 2025-12-07T21:23:57+08:00
New Revision: 1226a6d8c34ca007c4192e6039866a65b98b2625
URL: https://github.com/llvm/llvm-project/commit/1226a6d8c34ca007c4192e6039866a65b98b2625
DIFF: https://github.com/llvm/llvm-project/commit/1226a6d8c34ca007c4192e6039866a65b98b2625.diff
LOG: [clang-tidy] Fix fragile test in `read-parameters-from-file` (#171033)
[CommandLine.cpp](https://github.com/llvm/llvm-project/blob/fb0400fe1f1f9e83f3148db8ce2c72ab5bc6728e/llvm/lib/Support/CommandLine.cpp#L940)
treats single quote as literal characters on Windows, so the argument is
parsed as a check named `' -*,llvm-namespace-comment '`, which matches
no existing checks, so no checks are enabled via the command line.
Previously, the test passed because it fell back to the root
`.clang-tidy` configuration which enables `llvm-*`.
Added:
Modified:
clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
Removed:
################################################################################
diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt b/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
index a6d8fa7ee299f..5cf5693664f53 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
@@ -1,2 +1,2 @@
--checks='-*,llvm-namespace-comment'
+-checks=-*,llvm-namespace-comment
--warnings-as-errors=llvm-namespace-comment
More information about the cfe-commits
mailing list