[clang-tools-extra] [clang-tidy] Fix fragile test in `read-parameters-from-file` (PR #171033)

via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 7 04:10:31 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-tools-extra

Author: mitchell (zeyi2)

<details>
<summary>Changes</summary>

[CommandLine.cpp](https://github.com/llvm/llvm-project/blob/fb0400fe1f1f9e83f3148db8ce2c72ab5bc6728e/llvm/lib/Support/CommandLine.cpp#L940) treats single quote as literal characters on Windows, so the argument is parsed as a check named ' -*,llvm-namespace-comment ', which matches no existing checks, so no checks are enabled via the command line.

Previously, the test passed because it fell back to the root `.clang-tidy` configuration which enables `llvm-*`.

---
Full diff: https://github.com/llvm/llvm-project/pull/171033.diff


1 Files Affected:

- (modified) clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt (+1-1) 


``````````diff
diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt b/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
index a6d8fa7ee299f..5cf5693664f53 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
@@ -1,2 +1,2 @@
--checks='-*,llvm-namespace-comment'
+-checks=-*,llvm-namespace-comment
 --warnings-as-errors=llvm-namespace-comment

``````````

</details>


https://github.com/llvm/llvm-project/pull/171033


More information about the cfe-commits mailing list