[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Dec 6 14:37:00 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
index cf1a7dcd7..6b4d3b4fc 100644
--- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
+++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
@@ -2015,8 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite(
fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline);
}
- fn.setVisibility_(lowerCIRVisibilityToLLVMVisibility(
- op.getGlobalVisibility()));
+ fn.setVisibility_(
+ lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()));
rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end());
if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter,
@@ -2160,8 +2160,8 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite(
}
}
- mlir::LLVM::Visibility visibility = lowerCIRVisibilityToLLVMVisibility(
- op.getGlobalVisibility());
+ mlir::LLVM::Visibility visibility =
+ lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility());
mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter);
auto newOp = rewriter.replaceOpWithNewOp<mlir::LLVM::GlobalOp>(
op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()),
``````````
</details>
https://github.com/llvm/llvm-project/pull/171000
More information about the cfe-commits
mailing list