[clang] [SYCL] SYCL host kernel launch support for the sycl_kernel_entry_point attribute. (PR #152403)

[Erich Keane via cfe-commits]

================
@@ -898,6 +899,25 @@ static std::string convertCallArgsToString(Sema &S,
   return Result;
 }
 
+static std::string
+printCallArgsValueCategoryAndType(Sema &S, llvm::ArrayRef<const Expr *> Args) {
+  std::string Result;
+  llvm::raw_string_ostream OS(Result);
+  llvm::ListSeparator Comma;
+  OS << "(";
+  for (const Expr *Arg : Args) {
+    ExprValueKind EVK = Arg->getValueKind();
+    const char *ValueCategory =
+        (EVK == VK_LValue ? "lvalue"
----------------
erichkeane wrote:

Whats going on here?  This sort of printing is more of a 'dump' kinda thing, right?  IF we're using this for diagnostics, we've done SOMETHING seriously wrong either in implementation or design.

https://github.com/llvm/llvm-project/pull/152403