[clang] [clang] [diagnostics] Stable IDs for Clang diagnostics (PR #168153)

[Dave Bartolomeo via cfe-commits]

dbartol wrote:

@erichkeane 

> I think a better order: Add support for StableId, add explicit IDs, make explicit StableId required for warnings/errors. I don't see any value to the 'implicit' version in the meantime.

It's a bit more difficult to test the SARIF output without stable IDs. Without stable IDs, we were still using the integer value of the enum as the ID, which is obviously not stable, and had extra filtering in our tests to compensate. I don't think having the implicit stable IDs hurts anything in the short time it will take for me to write the update script and open the explicit stable IDs PR.


https://github.com/llvm/llvm-project/pull/168153