[clang] [LifetimeSafety] Suggest lifetime annotations (PR #169767)

[Utkarsh Saxena via cfe-commits]

================
@@ -342,4 +349,24 @@ void FactsGenerator::markUseAsWrite(const DeclRefExpr *DRE) {
   UseFacts[DRE]->markAsWritten();
 }
 
+// Creates an IssueFact for a new placeholder loan for each pointer or reference
+// parameter at the function's entry.
+llvm::SmallVector<Fact *> FactsGenerator::createPlaceholderLoanFacts() {
+  llvm::SmallVector<Fact *> PlaceholderLoanFacts;
+  const auto *FD = dyn_cast<FunctionDecl>(AC.getDecl());
+  if (!FD)
+    return PlaceholderLoanFacts;
----------------
usx95 wrote:

Move these to the top of the function and `return {} `​ to be clear.

https://github.com/llvm/llvm-project/pull/169767