[clang] [CodeGen][ObjC] Initial WebAssembly Support for GNUstep (PR #169043)
Hugo Melder via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 28 05:18:49 PST 2025
https://github.com/hmelder updated https://github.com/llvm/llvm-project/pull/169043
>From a07542b0e2274e36a9276ce034697ebcd0d0fee8 Mon Sep 17 00:00:00 2001
From: hmelder <service at hugomelder.com>
Date: Fri, 21 Nov 2025 10:42:47 +0000
Subject: [PATCH 1/3] [clang] Whitelist wasm when targeting GNUstep 2.x
---
clang/lib/Driver/ToolChains/Clang.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 30d3e5293a31b..6cbec5e17ae1a 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -8001,7 +8001,8 @@ ObjCRuntime Clang::AddObjCRuntimeArgs(const ArgList &args,
if ((runtime.getKind() == ObjCRuntime::GNUstep) &&
(runtime.getVersion() >= VersionTuple(2, 0)))
if (!getToolChain().getTriple().isOSBinFormatELF() &&
- !getToolChain().getTriple().isOSBinFormatCOFF()) {
+ !getToolChain().getTriple().isOSBinFormatCOFF() &&
+ !getToolChain().getTriple().isOSBinFormatWasm()) {
getToolChain().getDriver().Diag(
diag::err_drv_gnustep_objc_runtime_incompatible_binary)
<< runtime.getVersion().getMajor();
>From 627484c8341dc4ee1418670855a288e300f6c669 Mon Sep 17 00:00:00 2001
From: hmelder <service at hugomelder.com>
Date: Fri, 21 Nov 2025 10:50:35 +0000
Subject: [PATCH 2/3] [CodeGen][ObjC] Mangle public symbols for wasm
Emscripten requires that exported symbols. See
https://github.com/emscripten-core/emscripten/pull/23563.
---
clang/lib/CodeGen/CGObjCGNU.cpp | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/clang/lib/CodeGen/CGObjCGNU.cpp b/clang/lib/CodeGen/CGObjCGNU.cpp
index 06643d4bdc211..12719299028b7 100644
--- a/clang/lib/CodeGen/CGObjCGNU.cpp
+++ b/clang/lib/CodeGen/CGObjCGNU.cpp
@@ -179,8 +179,14 @@ class CGObjCGNU : public CGObjCRuntime {
(R.getVersion() >= VersionTuple(major, minor));
}
- std::string ManglePublicSymbol(StringRef Name) {
- return (StringRef(CGM.getTriple().isOSBinFormatCOFF() ? "$_" : "._") + Name).str();
+ const std::string ManglePublicSymbol(StringRef Name) {
+ StringRef prefix = "._"
+
+ // Exported symbols in Emscripten must be a valid Javascript identifier.
+ auto triple = CGM.getTriple();
+ if (triple.isOSBinFormatCOFF() || triple.isOSBinFormatWasm()) {
+ prefix = "$_";
+ return (prefix + Name).str();
}
std::string SymbolForProtocol(Twine Name) {
>From ba4cbb0fbd5168a0487e63211bfb37e09d61c679 Mon Sep 17 00:00:00 2001
From: hmelder <service at hugomelder.com>
Date: Fri, 21 Nov 2025 13:04:33 +0000
Subject: [PATCH 3/3] [CodeGen][ObjC] Fix class_registerAlias_np signature
---
clang/lib/CodeGen/CGObjCGNU.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/clang/lib/CodeGen/CGObjCGNU.cpp b/clang/lib/CodeGen/CGObjCGNU.cpp
index 12719299028b7..c6c8f68ed57c8 100644
--- a/clang/lib/CodeGen/CGObjCGNU.cpp
+++ b/clang/lib/CodeGen/CGObjCGNU.cpp
@@ -4112,8 +4112,7 @@ llvm::Function *CGObjCGNU::ModuleInitFunction() {
if (!ClassAliases.empty()) {
llvm::Type *ArgTypes[2] = {PtrTy, PtrToInt8Ty};
llvm::FunctionType *RegisterAliasTy =
- llvm::FunctionType::get(Builder.getVoidTy(),
- ArgTypes, false);
+ llvm::FunctionType::get(BoolTy, ArgTypes, false);
llvm::Function *RegisterAlias = llvm::Function::Create(
RegisterAliasTy,
llvm::GlobalValue::ExternalWeakLinkage, "class_registerAlias_np",
More information about the cfe-commits
mailing list